Fix CalDAV update if sync is set #1703
Conversation
Codecov ReportBase: 97.27% // Head: 97.28% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1703 +/- ##
==========================================
+ Coverage 97.27% 97.28% +0.01%
==========================================
Files 643 645 +2
Lines 9689 9725 +36
==========================================
+ Hits 9425 9461 +36
Misses 264 264
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
| await this.gladys.calendar.update(gladysCalendar[0].selector, formatedCalendar); | ||
| await this.gladys.calendar.update(gladysCalendar[0].selector, { | ||
| ...formatedCalendar, | ||
| sync: gladysCalendar[0].sync, |
There was a problem hiding this comment.
Don't you risk to still update it wrongly if it changed between the .get and the .update ?
Why not simply removing the sync attribute from the update if it's not required?
There was a problem hiding this comment.
There is no action between get and update, so time is really, really short, I don't think change can happen. But indeed delete is a better option, more readable I changed.
Job #1057: Bundle Size — 7.19MiB (0%).
Metrics (1 change)
Total size by type (no changes)
|
Pull Request check-list
To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:
npm teston both front/server)npm run eslinton both front/server)npm run prettieron both front/server)NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
Description of change
If CalDAV calendar is updated while sync, do not updated sync attribute