Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caldav: Improve calendar sharing wording #1698

Merged
merged 1 commit into from
Jan 27, 2023

Conversation

Pierre-Gilles
Copy link
Contributor

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)

Description of change

FR:
Screenshot 2023-01-26 at 10 02 24

EN:
Screenshot 2023-01-26 at 10 03 46

@cloudflare-workers-and-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: ec795b3
Status: ✅  Deploy successful!
Preview URL: https://055970b3.gladys-plus.pages.dev
Branch Preview URL: https://improve-calendar-sharing-wor.gladys-plus.pages.dev

View logs

@codecov
Copy link

codecov bot commented Jan 26, 2023

Codecov Report

Base: 97.28% // Head: 97.28% // No change to project coverage 👍

Coverage data is based on head (ec795b3) compared to base (ec6628b).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1698   +/-   ##
=======================================
  Coverage   97.28%   97.28%           
=======================================
  Files         644      644           
  Lines        9712     9712           
=======================================
  Hits         9448     9448           
  Misses        264      264           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@relativeci
Copy link

relativeci bot commented Jan 26, 2023

Job #1034: Bundle Size — 7.04MiB (~+0.01%).

c3d6921(current) vs 7cc7b29 master#1032(baseline)

Metrics (2 changes)
                 Current
Job #1034
     Baseline
Job #1032
Initial JS 3.05MiB(+0.02%) 3.05MiB
Initial CSS 296.8KiB 296.8KiB
Cache Invalidation 43.17% 43.15%
Chunks 51 51
Assets 148 148
Modules 1260 1260
Duplicate Modules 2 2
Duplicate Code 0.03% 0.03%
Packages 111 111
Duplicate Packages 8 8
Total size by type (1 change)
                 Current
Job #1034
     Baseline
Job #1032
CSS 312.43KiB 312.43KiB
Fonts 93.55KiB 93.55KiB
HTML 13.58KiB 13.58KiB
IMG 1.66MiB 1.66MiB
JS 4.97MiB (+0.01%) 4.97MiB
Media 0B 0B
Other 4.9KiB 4.9KiB

View job #1034 reportView master branch activity

@Pierre-Gilles Pierre-Gilles merged commit c3d6921 into master Jan 27, 2023
@Pierre-Gilles Pierre-Gilles deleted the improve-calendar-sharing-wording branch January 27, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant