Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error message on Ecowatt box if request fails #1664

Merged
merged 1 commit into from
Dec 9, 2022

Conversation

Pierre-Gilles
Copy link
Contributor

@Pierre-Gilles Pierre-Gilles commented Dec 9, 2022

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community for testing before merging.

Description of change

Screenshot 2022-12-09 at 19 27 22

@cloudflare-workers-and-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 62d9b51
Status: ✅  Deploy successful!
Preview URL: https://16ed0076.gladys-plus.pages.dev
Branch Preview URL: https://add-error-message-ecowatt.gladys-plus.pages.dev

View logs

@codecov
Copy link

codecov bot commented Dec 9, 2022

Codecov Report

Base: 97.25% // Head: 97.25% // No change to project coverage 👍

Coverage data is based on head (62d9b51) compared to base (c9484ca).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1664   +/-   ##
=======================================
  Coverage   97.25%   97.25%           
=======================================
  Files         642      642           
  Lines        9671     9671           
=======================================
  Hits         9406     9406           
  Misses        265      265           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@relativeci
Copy link

relativeci bot commented Dec 9, 2022

Job #848: Bundle Size — 6.96MiB (+0.01%).

b4873e5(current) vs c9484ca master#846(baseline)

Metrics (2 changes)
                 Current
Job #848
     Baseline
Job #846
Initial JS 3.01MiB(+0.01%) 3.01MiB
Initial CSS 293.57KiB 293.57KiB
Cache Invalidation 58.8% 0%
Chunks 52 52
Assets 148 148
Modules 1238 1238
Duplicate Modules 2 2
Duplicate Code 0.03% 0.03%
Packages 106 106
Duplicate Packages 8 8
Total size by type (1 change)
                 Current
Job #848
     Baseline
Job #846
CSS 310.75KiB 310.75KiB
Fonts 93.55KiB 93.55KiB
HTML 13.58KiB 13.58KiB
IMG 1.64MiB 1.64MiB
JS 4.91MiB (+0.02%) 4.91MiB
Media 0B 0B
Other 4.95KiB 4.95KiB

View job #848 reportView master branch activity

@Pierre-Gilles Pierre-Gilles merged commit b4873e5 into master Dec 9, 2022
@Pierre-Gilles Pierre-Gilles deleted the add-error-message-ecowatt branch December 9, 2022 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant