Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Google Home/Alexa links #1582

Merged
merged 1 commit into from
Aug 4, 2022
Merged

Conversation

Pierre-Gilles
Copy link
Contributor

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community for testing before merging.
  • If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • Did you add fake requests data for the demo mode (front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Please provide a description of the change here. It's always best with screenshots, so don't hesitate to add some!

@Pierre-Gilles Pierre-Gilles marked this pull request as ready for review August 4, 2022 09:32
@codecov
Copy link

codecov bot commented Aug 4, 2022

Codecov Report

Merging #1582 (b2b6d37) into master (cdc7d77) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1582   +/-   ##
=======================================
  Coverage   96.64%   96.64%           
=======================================
  Files         630      630           
  Lines        9267     9267           
=======================================
  Hits         8956     8956           
  Misses        311      311           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@relativeci
Copy link

relativeci bot commented Aug 4, 2022

Job #411: Bundle Size — 6.84MB (~+0.01%).

ce21420 vs cdc7d77

Changed metrics (2/10)
Metric Current Baseline
Initial JS 2.88MB(~+0.01%) 2.88MB
Cache Invalidation 41.99% 41.98%
Changed assets by type (1/7)
            Current     Baseline
JS 4.87MB (~+0.01%) 4.87MB

View Job #411 report on app.relative-ci.com

@Pierre-Gilles Pierre-Gilles merged commit ce21420 into master Aug 4, 2022
@Pierre-Gilles Pierre-Gilles deleted the fix-alexa-google-home-links branch August 4, 2022 13:26
euguuu pushed a commit to euguuu/Gladys that referenced this pull request Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant