Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clock box for dashboard #1509

Merged
merged 12 commits into from
Jan 2, 2023

Conversation

callemand
Copy link
Contributor

@callemand callemand commented Apr 19, 2022

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community for testing before merging.
  • If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • Did you add fake requests data for the demo mode (front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

The purpose of this PR is a proposal to add box on dashboard to display a clock.

Screenshot 2022-05-08 at 12 41 07
Screenshot 2022-05-08 at 12 41 29

Settings:
Screenshot 2022-05-08 at 12 42 20
Screenshot 2022-05-08 at 12 43 43

@codecov
Copy link

codecov bot commented Apr 19, 2022

Codecov Report

Base: 97.26% // Head: 97.26% // No change to project coverage 👍

Coverage data is based on head (0c885a8) compared to base (5154c19).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1509   +/-   ##
=======================================
  Coverage   97.26%   97.26%           
=======================================
  Files         643      643           
  Lines        9684     9684           
=======================================
  Hits         9419     9419           
  Misses        265      265           
Impacted Files Coverage Δ
server/models/dashboard.js 100.00% <ø> (ø)
server/utils/constants.js 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@callemand callemand marked this pull request as ready for review April 22, 2022 18:09
Copy link
Contributor

@atrovato atrovato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried on my computer, but analog clock doesn't work well (left element).

clock

And I think we may have to choice to display seconds or not, it is stressing me :D

front/src/config/i18n/en.json Show resolved Hide resolved
front/src/components/boxs/clock/Clock.jsx Outdated Show resolved Hide resolved
@callemand
Copy link
Contributor Author

display seconds or not, i

I tried on my computer, but analog clock doesn't work well (left element).

clock

I found the error, It's the default value of the edit box send an undefined, fixing in progress :)

And I think we may have to choice to display seconds or not, it is stressing me :D

Yes, It's a good idea 👍

@callemand
Copy link
Contributor Author

@atrovato : I have added an options to display or not the second, I have updated the screenshot

@stale
Copy link

stale bot commented Jul 17, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 17, 2022
@atrovato
Copy link
Contributor

I will re-try this, sorry for the delay.

@stale stale bot closed this Jul 25, 2022
@atrovato atrovato reopened this Jul 25, 2022
@stale stale bot removed the stale label Jul 25, 2022
Copy link
Contributor

@atrovato atrovato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, it is quite better.
Look's good to me.

front/src/components/boxs/clock/Clock.jsx Outdated Show resolved Hide resolved
front/src/components/boxs/clock/style.css Outdated Show resolved Hide resolved
front/src/style/index.css Outdated Show resolved Hide resolved
front/src/style/index.css Outdated Show resolved Hide resolved
Copy link
Contributor

@atrovato atrovato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix conflicts and handle all comments :)

@stale
Copy link

stale bot commented Nov 14, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 14, 2022
@stale stale bot closed this Nov 21, 2022
@callemand callemand reopened this Dec 12, 2022
@stale stale bot removed the stale label Dec 12, 2022
Copy link
Contributor

@Pierre-Gilles Pierre-Gilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to update this PR 🙏

The code is good to me expect one little detail (nothing serious)

Functionally, the design of the month seems a bit big to me, I guess it's because it was designed in May when the month was small, and now we are in December 😂

What about making the "17 décembre" smaller, and a bit more compact (less spacing between the two) ?

Screenshot 2022-12-17 at 15 00 44

front/src/config/i18n/en.json Show resolved Hide resolved
server/utils/constants.js Outdated Show resolved Hide resolved
Copy link
Contributor

@Pierre-Gilles Pierre-Gilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes 🙏

Good for me for the code, just can you add the text-monospace class to the numeric time so that there is no "glitch"

See my comment here: https://community.gladysassistant.com/t/afficher-lheure-sur-le-dashboard/7071/38?u=pierre-gilles

Copy link
Contributor

@Pierre-Gilles Pierre-Gilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me now! Thanks for this PR 🙏

@Pierre-Gilles Pierre-Gilles merged commit 3df107c into GladysAssistant:master Jan 2, 2023
@relativeci
Copy link

relativeci bot commented Jan 2, 2023

Job #938: Bundle Size — 7MiB (+0.44%).

3df107c(current) vs 7eb0b2a master#908(baseline)

Metrics (5 changes)
                 Current
Job #938
     Baseline
Job #908
Initial JS 3.03MiB(+0.03%) 3.02MiB
Initial CSS 294.78KiB(+0.3%) 293.9KiB
Cache Invalidation 63.03% 0%
Chunks 52 52
Assets 148 148
Modules 1258(+1.29%) 1242
Duplicate Modules 2 2
Duplicate Code 0.03% 0.03%
Packages 111(+4.72%) 106
Duplicate Packages 8 8
Total size by type (2 changes)
                 Current
Job #938
     Baseline
Job #908
CSS 312.43KiB (+0.43%) 311.09KiB
Fonts 93.55KiB 93.55KiB
HTML 13.58KiB 13.58KiB
IMG 1.64MiB 1.64MiB
JS 4.95MiB (+0.59%) 4.92MiB
Media 0B 0B
Other 4.95KiB 4.95KiB

View job #938 reportView master branch activity

@callemand callemand deleted the DashboardClock branch July 11, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants