-
-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add clock box for dashboard #1509
Add clock box for dashboard #1509
Conversation
7aa15a4
to
17e1890
Compare
Codecov ReportBase: 97.26% // Head: 97.26% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #1509 +/- ##
=======================================
Coverage 97.26% 97.26%
=======================================
Files 643 643
Lines 9684 9684
=======================================
Hits 9419 9419
Misses 265 265
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
17e1890
to
8efbd31
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found the error, It's the default value of the edit box send an undefined, fixing in progress :)
Yes, It's a good idea 👍 |
@atrovato : I have added an options to display or not the second, I have updated the screenshot |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
I will re-try this, sorry for the delay. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, it is quite better.
Look's good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix conflicts and handle all comments :)
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
fb356e7
to
3350658
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking the time to update this PR 🙏
The code is good to me expect one little detail (nothing serious)
Functionally, the design of the month seems a bit big to me, I guess it's because it was designed in May when the month was small, and now we are in December 😂
What about making the "17 décembre" smaller, and a bit more compact (less spacing between the two) ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes 🙏
Good for me for the code, just can you add the text-monospace class to the numeric time so that there is no "glitch"
See my comment here: https://community.gladysassistant.com/t/afficher-lheure-sur-le-dashboard/7071/38?u=pierre-gilles
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good for me now! Thanks for this PR 🙏
Job #938: Bundle Size — 7MiB (+0.44%).
Metrics (5 changes)
Total size by type (2 changes)
|
Pull Request check-list
To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:
npm test
on both front/server)npm run eslint
on both front/server)npm run prettier
on both front/server)npm run compare-translations
on front)front/src/config/demo.js
) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
Description of change
The purpose of this PR is a proposal to add box on dashboard to display a clock.
Settings:
![Screenshot 2022-05-08 at 12 42 20](https://user-images.githubusercontent.com/11317212/167292496-19cfcb49-167e-4fec-a81c-d2ec0ac7c8f7.png)
![Screenshot 2022-05-08 at 12 43 43](https://user-images.githubusercontent.com/11317212/167292513-ea89f632-5273-4ef1-833f-07e31972cfcf.png)