Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashbaord CO with colored badge #1472

Merged

Conversation

atrovato
Copy link
Contributor

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • [ ] If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • [ ] If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • [ ] Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community for testing before merging.
  • [ ] If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • [ ] If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • [ ] Did you add fake requests data for the demo mode (front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

CO sensor as colored badge.
https://community.gladysassistant.com/t/type-qualite-de-lair-natif-avec-couleurs-en-fonction-de-la-valeur/7014

A little refacto to allow to enlarge easily and clearly the way to display sensor values.

image

@codecov
Copy link

codecov bot commented Mar 16, 2022

Codecov Report

Merging #1472 (bc61cd9) into master (3800a76) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1472   +/-   ##
=======================================
  Coverage   96.59%   96.59%           
=======================================
  Files         616      616           
  Lines        8887     8887           
=======================================
  Hits         8584     8584           
  Misses        303      303           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3800a76...bc61cd9. Read the comment docs.

Copy link
Contributor

@Pierre-Gilles Pierre-Gilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems the "door opening sensor" are not working when in position 1 :

Screenshot 2022-03-18 at 08 49 12

Otherwise, very nice PR ! It works fine for the Co2 part :)

@atrovato
Copy link
Contributor Author

You're right, I wrote shield-on instead of shiled as icon class.

@atrovato atrovato force-pushed the colored-ppm-air-quality branch from 064e622 to bc61cd9 Compare March 18, 2022 19:35
@atrovato atrovato requested a review from Pierre-Gilles March 18, 2022 19:35
Copy link
Contributor

@Pierre-Gilles Pierre-Gilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for your PR 🙏

@Pierre-Gilles Pierre-Gilles merged commit 58aeb37 into GladysAssistant:master Mar 22, 2022
@relativeci
Copy link

relativeci bot commented Mar 22, 2022

Job #245: Bundle Size — 6.73MB (+0.04%).

58aeb37 vs ad1f9a0

Changed metrics (4/10)
Metric Current Baseline
Cache Invalidation 60.15% 0%
Modules 1054(+0.38%) 1050
Duplicate Modules 17(+30.77%) 13
Duplicate Code 0.48%(+11.63%) 0.43%
Changed assets by type (1/7)
            Current     Baseline
JS 4.83MB (+0.05%) 4.82MB

View Job #245 report on app.relative-ci.com

@Pierre-Gilles
Copy link
Contributor

@atrovato Just one question, where did you find your values for the Co2 limits ?

I find way different values online:

Screenshot 2022-03-22 at 09 26 34

@Pierre-Gilles
Copy link
Contributor

Indice-PPM-1-1024x538

@atrovato atrovato deleted the colored-ppm-air-quality branch October 31, 2022 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants