-
-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dashbaord CO with colored badge #1472
Dashbaord CO with colored badge #1472
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1472 +/- ##
=======================================
Coverage 96.59% 96.59%
=======================================
Files 616 616
Lines 8887 8887
=======================================
Hits 8584 8584
Misses 303 303 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, I wrote |
064e622
to
bc61cd9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks for your PR 🙏
Job #245: Bundle Size — 6.73MB (+0.04%).Changed metrics (4/10)
|
@atrovato Just one question, where did you find your values for the Co2 limits ? I find way different values online: |
Pull Request check-list
To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:
[ ] If your changes affects code, did your write the tests?npm test
on both front/server)npm run eslint
on both front/server)npm run prettier
on both front/server)[ ] If you are adding a new features/services, did you run integration comparator? (npm run compare-translations
on front)[ ] Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community for testing before merging.[ ] If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)[ ] If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.[ ] Did you add fake requests data for the demo mode (front/src/config/demo.js
) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
Description of change
CO sensor as colored badge.
https://community.gladysassistant.com/t/type-qualite-de-lair-natif-avec-couleurs-en-fonction-de-la-valeur/7014
A little refacto to allow to enlarge easily and clearly the way to display sensor values.