[FRONT] Box Humidity in Room

[VonOx]

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

• If your changes affects code, did your write the tests?
• Are tests passing? (npm test on both front/server)
• Is the linter passing? (npm run eslint on both front/server)
• Did you run prettier? (npm run prettier on both front/server)
• If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
• If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
• If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
• Did you add fake requests data for the demo mode (front/src/config/demo.json) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

New box "Humidity in room" , duplicated from "Temperature in room"

Color is adjusted based on value

Between 45 - 60 % => Green ( Humidity ok )

Under 45 => Yellow ( too dry )

Below 60% => Blue ( too moist )

[codecov]

Codecov Report

Merging #1045 (a6df113) into master (a0232ae) will increase coverage by 0.05%.
The diff coverage is 100.00%.

❗ Current head a6df113 differs from pull request most recent head 185b94a. Consider uploading reports for the commit 185b94a to get more accurate results

@@            Coverage Diff             @@
##           master    #1045      +/-   ##
==========================================
+ Coverage   95.80%   95.86%   +0.05%     
==========================================
  Files         533      536       +3     
  Lines        7222     7277      +55     
==========================================
+ Hits         6919     6976      +57     
+ Misses        303      301       -2     

Impacted Files	Coverage Δ
server/seeders/20190227081700-device-feature.js	100.00% <ø> (ø)
server/utils/constants.js	100.00% <ø> (ø)
server/api/controllers/room.controller.js	100.00% <100.00%> (ø)
.../device/humidity-sensor/humidity-sensor.command.js	100.00% <100.00%> (ø)
...midity-sensor/humidity-sensor.getHumidityInRoom.js	100.00% <100.00%> (ø)
server/lib/device/humidity-sensor/index.js	100.00% <100.00%> (ø)
server/lib/device/index.js	100.00% <100.00%> (ø)
... and 1 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fecd2e7...185b94a. Read the comment docs.

[atrovato]

I think we are go to have a generic "sensor box". Adding a box for each kind of sensor, we'll get a very long list of bashboard boxes.

[atrovato]

Code is good enough, didn't test it.

[cicoub13]

You missed adding your box in the type box list in backend (file server/utils/constant.js)

const DASHBOARD_BOX_TYPE = {
  WEATHER: 'weather',
  TEMPERATURE_IN_ROOM: 'temperature-in-room',
  HUMIDITY_IN_ROOM: 'humidity-in-room',
  USER_PRESENCE: 'user-presence',
  CAMERA: 'camera',
  DEVICES_IN_ROOM: 'devices-in-room',
};

And I think the backend call with ?expand=humidity doesn't seem to work.

[atrovato]

Now you miss tests on error cases... courage!

[atrovato]

Some code improvment.

[atrovato]

👍

[Pierre-Gilles]

Doesn't feel quite natural:

[VonOx]

@Pierre-Gilles You are right , I've commit a better answer

[Pierre-Gilles]

A few feedbacks

[Pierre-Gilles]

Looks good to me except a small typo :)

[Pierre-Gilles]

Good to me now!