-
-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #1021 service status #1022
Fix #1021 service status #1022
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1022 +/- ##
==========================================
- Coverage 94.96% 94.96% -0.01%
==========================================
Files 523 523
Lines 6937 6934 -3
==========================================
- Hits 6588 6585 -3
Misses 349 349
Continue to review full report at Codecov.
|
server/migrations/20201220100508-service-remove-not-configured-status.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good for me!
* Remove NOT_CONFIGURED service status * Stopped service only on user request * Use Sequelize instead of SQL Co-authored-by: Pierre-Gilles Leymarie <pierregilles.leymarie@gmail.com>
Fixes #1021
Pull Request check-list
To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:
npm test
on both front/server)npm run eslint
on both front/server)npm run prettier
on both front/server)npm run compare-translations
on front)[ ] If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)[ ] If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.front/src/config/demo.json
) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
Description of change
Change service status management.
No NOT_CONFIGURED status.
Service STOPPED status only on user request.