Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1021 service status #1022

Merged

Conversation

atrovato
Copy link
Contributor

@atrovato atrovato commented Dec 20, 2020

Fixes #1021

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • [ ] If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • [ ] If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • Did you add fake requests data for the demo mode (front/src/config/demo.json) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Change service status management.
No NOT_CONFIGURED status.
Service STOPPED status only on user request.

@codecov
Copy link

codecov bot commented Dec 20, 2020

Codecov Report

Merging #1022 (f048c81) into master (e047cee) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1022      +/-   ##
==========================================
- Coverage   94.96%   94.96%   -0.01%     
==========================================
  Files         523      523              
  Lines        6937     6934       -3     
==========================================
- Hits         6588     6585       -3     
  Misses        349      349              
Impacted Files Coverage Δ
server/lib/service/service.startAll.js 94.73% <ø> (-0.51%) ⬇️
server/utils/constants.js 100.00% <ø> (ø)
server/api/controllers/service.controller.js 100.00% <100.00%> (ø)
server/lib/service/service.start.js 100.00% <100.00%> (ø)
server/lib/service/service.stop.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e047cee...f048c81. Read the comment docs.

Copy link
Contributor

@Pierre-Gilles Pierre-Gilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me!

@Pierre-Gilles Pierre-Gilles merged commit 9024d4b into GladysAssistant:master Dec 21, 2020
atrovato added a commit to atrovato/Gladys that referenced this pull request Feb 21, 2021
* Remove NOT_CONFIGURED service status

* Stopped service only on user request

* Use Sequelize instead of SQL

Co-authored-by: Pierre-Gilles Leymarie <pierregilles.leymarie@gmail.com>
@atrovato atrovato deleted the fix-#1021-service-status branch November 28, 2021 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Service status detection
2 participants