-
-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Birthdate bug on registration #14
Comments
The date should be in the "DD/MM/YYYY" format! If you are on chrome there is a datetime picker box which should appear. But you are right, the message is ugly for the user, I add this to my bug list, thx for your feedback :) |
Thx for the quick reply :-) Btw, good work! Still need a lot more, I will probably contribute in the next weeks! |
Hum.. Some people have troubles too with email validation, that's very weird maybe sails validator isn't working well... I'm going to investigate :) Great ! If you want to contribute, there are two ways :
|
même probléme avec la date de naissance impossble de passer l'enregistrement utilisateur : J'utlise firefox pas de chrome; comment je passe ce formulaire d'inscrption ? j'ai essayer ces format ça passe pas : 01012001 ça passe pas ???? |
Si besoin, je pourrai proposer un fix prochainement ! |
Petite question, l'interface que tu as es en anglais ou français ? Est-ce que tu pourrais tester en utilisant un format de date anglais ? ( YYYY-MM-DD ). Je soupçonne sails de s'adapter à la langue. |
Effectivement ça fonctionne avec la date à l'anglais sous fifrefox |
Très bien, du coup ça n'est pas un bug alors, juste que sails.js s'adapte à la langue de l'utilisateur pour demander la langue dans le bon format :) Il faudrait juste le préciser à l'utilisateur, mais ça me rassure ça n'est pas un bug. |
I'm reopening that question as I think we should do something more userfriendly. That is IMO a huge blocker when people want to try the application. Not having information about how to create a simple account might let people think that the software is not easy to use; Are you saying, that the date format in the registration page is YYYY-MM-DD when the browser locale is set to en-EN and that it become DD/MM/YYYY when it is set to fr-FR ? If so, I propose to create a new parameter in the config/locales/*.json, named "birthday-pattern". We should set its values to "YYYY-MM-DD" for en.json, "JJ/MM/AAAA" for fr.json (and appropriate variations for the others). What do you think, should I do it and propose a PR ? |
I definitely agree with you ! That's what I was planning to do but with all the little things I have to fix everywhere, I didn't do it.. Don't hesitate to propose a PR :) Thanks for proposing ! |
Cool, I'll do it tomorrow then. |
Cannot register myself using the form (birthdate bug):
The text was updated successfully, but these errors were encountered: