Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tight layout by default in Raster.plot() #617

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

rhugonnet
Copy link
Member

Resolves #616

@rhugonnet rhugonnet merged commit a548d06 into GlacioHack:main Oct 30, 2024
22 checks passed
@rhugonnet rhugonnet deleted the plot_tightlayout_default branch October 30, 2024 21:34
Copy link
Member

@adehecq adehecq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just seeing this. I think it could potentially lead to issues difficult to track later on with people trying to have multiple subplots, no?

@rhugonnet
Copy link
Member Author

Yes, I wondered that too. But I haven't had any since then using multiple subplots at many instances (our documentations or for the book chapter).
Sometimes I have to re-call tight_layout() for the plot containing subplots to look nice too, but that seems to work.

We can open an issue in the future in we bump into it I guess (or if you have an idea of a case that could fail, test it quickly now)

@adehecq
Copy link
Member

adehecq commented Jan 30, 2025

No, I don't have a problematic case in mind at the moment. So let's wait and see ! 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default Raster.plot() can have out-of-frame colorbar
2 participants