Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error decoding bridge events #223

Merged
merged 1 commit into from
Aug 9, 2020
Merged

Fix error decoding bridge events #223

merged 1 commit into from
Aug 9, 2020

Conversation

dapplion
Copy link
Contributor

@dapplion dapplion commented Aug 9, 2020

Patches @ethersproject/abi, to fix this issue ethers-io/ethers.js#992 (comment)

Haven't tested it outside of a sample script, please make sure it actually fixes the problem.

Afterwards

Track issue and once it's fixed bump library and remove patch-package

@aminlatifi
Copy link
Member

Great work @dapplion

@aminlatifi aminlatifi merged commit 6709344 into Giveth:develop Aug 9, 2020
@aminlatifi
Copy link
Member

Simulation script does not work as expected though

@dapplion
Copy link
Contributor Author

dapplion commented Aug 9, 2020

@aminlatifi Can you paste here error logs and more info about why not?

@aminlatifi
Copy link
Member

@aminlatifi Can you paste here error logs and more info about why not?

It has been solved, not related to your update

@dapplion dapplion deleted the fix-decode-events branch August 11, 2020 10:43
@ricmoo
Copy link

ricmoo commented Sep 8, 2020

I've added support in ethers 5.0.12 for supporting legacy Solidity 0.4 external event data.

A quick note regarding this PR: You should only enable loose parsing for events. Attempting to parse call results with a loose parser is not possible (and unsafe) since incorrectly formatted call data could possibly be an error parsed as a non-error or a non-error parsed as an error (e.g. if a call result had a bytes of length 4, the data as a whole would be interpreted as an EIP-838 error, and the decoding would begin at the wrong position).

For more details, please see ethers-io/ethers.js#891.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants