Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Array-based version #148

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

steguar
Copy link

@steguar steguar commented Apr 14, 2020

Ciao Giulio, tutti,

sono Stefano Guarino, ho creato un branch con le mie modifiche e, come suggerito da Giulio, inoltrato una pull request. Resto in attesa.

A presto,
S

Pull Request Template(s)

βš›πŸ‘‹ Hello there! Welcome. Please follow the steps below to tell us about your contribution.

  1. Copy the correct template for your contribution (see below)
  2. Replace this text with the contents of the template
  3. Fill in all sections of the template
  4. Click "Create pull request"

πŸ› Are you fixing a bug?

  • Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • The pull request must only fix an existing bug. To contribute other changes, you must use a different template.
  • The pull request must update the test suite to demonstrate the changed functionality.
  • After you create the pull request, all status checks must be pass before a maintainer reviews your contribution.

Identify the Bug

Link to the issue describing the bug that you're fixing.

If there is not yet an issue for your bug, please open a new issue and then link to that issue in your pull request.
Note: In some cases, one person's "bug" is another person's "feature." If the pull request does not address an existing issue with the "bug" label, the maintainers have the final say on whether the current behavior is a bug.

Description of the Change

We must be able to understand the design of your change from this description. If we can't get a good idea of what the code will be doing from the description here, the pull request may be closed at the maintainers' discretion. Keep in mind that the maintainer reviewing this PR may not be familiar with or have worked with the code here recently, so please walk us through the concepts.

Alternate Designs

Explain what other alternates were considered and why the proposed version was selected

Possible Drawbacks

What are the possible side-effects or negative impacts of the code change?

Verification Process

What process did you follow to verify that the change has not introduced any regressions? Describe the actions you performed (including buttons you clicked, text you typed, commands you ran, etc.), and describe the results you observed.

Release Notes

Please describe the changes in a single line that explains this improvement in
terms that a user can understand. This text will be used in NDlib's release notes.

If this change is not user-facing or notable enough to be included in release notes
you may use the strings "Not applicable" or "N/A" here.

Examples:

  • The GitHub package now allows you to add co-authors to commits.
  • Fixed an issue where multiple cursors did not work in a file with a single line.
  • Increased the performance of searching and replacing across a whole project.

πŸ“ˆ Are you improving performances?

  • Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • The pull request must only affect performance of existing functionality. To contribute other changes, you must use a different template.
  • After you create the pull request, all status checks must be pass before a maintainer reviews your contribution.

Description of the Change

We must be able to understand the design of your change from this description. If we can't get a good idea of what the code will be doing from the description here, the pull request may be closed at the maintainers' discretion. Keep in mind that the maintainer reviewing this PR may not be familiar with or have worked with the code here recently, so please walk us through the concepts.

Quantitative Performance Benefits

Describe the exact performance improvement observed (for example, reduced time to complete an operation, reduced memory use, etc.). Describe how you measured this change. Bonus points for including graphs that demonstrate the improvement or attached dumps from the built-in profiling tools.

Possible Drawbacks

What are the possible side-effects or negative impacts of the code change?

Verification Process

What process did you follow to verify that the change has not introduced any regressions? Describe the actions you performed (including buttons you clicked, text you typed, commands you ran, etc.), and describe the results you observed.

Applicable Issues

Enter any applicable Issues here

Release Notes

Please describe the changes in a single line that explains this improvement in
terms that a user can understand. This text will be used in NDlib's release notes.

If this change is not user-facing or notable enough to be included in release notes
you may use the strings "Not applicable" or "N/A" here.

Examples:

  • The GitHub package now allows you to add co-authors to commits.
  • Fixed an issue where multiple cursors did not work in a file with a single line.
  • Increased the performance of searching and replacing across a whole project.

πŸ“ Are you updating documentation?

  • Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • The pull request must only contribute documentation (for example, markdown files or API docs). To contribute other changes, you must use a different template.

Description of the Change

We must be able to understand the purpose of your change from this description. If we can't get a good idea of the benefits of the change from the description here, the pull request may be closed at the maintainers' discretion.

Release Notes

Please describe the changes in a single line that explains this improvement in
terms that a user can understand. This text will be used in NDlib's release notes.

If this change is not user-facing or notable enough to be included in release notes
you may use the strings "Not applicable" or "N/A" here.

Examples:

  • The GitHub package now allows you to add co-authors to commits.
  • Fixed an issue where multiple cursors did not work in a file with a single line.
  • Increased the performance of searching and replacing across a whole project.

πŸ’» Are you changing functionalities?

  • Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • The pull request must contribute a change that has been endorsed by the maintainer team. See details in the template below.
  • The pull request must update the test suite to exercise the updated functionality.
  • After you create the pull request, all status checks must be pass before a maintainer reviews your contribution.

Issue or RFC Endorsed by NDlib's Maintainers

Link to the issue or RFC that your change relates to. This must be one of the following:

  • An open issue with the help-wanted label
  • An open issue with the triaged label
  • An RFC with "accepted" status

To contribute other changes, you must use a different template.

Description of the Change

We must be able to understand the design of your change from this description. If we can't get a good idea of what the code will be doing from the description here, the pull request may be closed at the maintainers' discretion. Keep in mind that the maintainer reviewing this PR may not be familiar with or have worked with the code here recently, so please walk us through the concepts.

Alternate Designs

Explain what other alternates were considered and why the proposed version was selected

Possible Drawbacks

What are the possible side-effects or negative impacts of the code change?

Verification Process

What process did you follow to verify that your change has the desired effects?

  • How did you verify that all new functionality works as expected?
  • How did you verify that all changed functionality works as expected?
  • How did you verify that the change has not introduced any regressions?

Describe the actions you performed (including buttons you clicked, text you typed, commands you ran, etc.), and describe the results you observed.

Release Notes

Please describe the changes in a single line that explains this improvement in
terms that a user can understand. This text will be used in NDlib's release notes.

If this change is not user-facing or notable enough to be included in release notes
you may use the strings "Not applicable" or "N/A" here.

Examples:# Pull Request Template(s)
βš›πŸ‘‹ Hello there! Welcome. Please follow the steps below to tell us about your contribution.

  1. Copy the correct template for your contribution (see below)
  2. Replace this text with the contents of the template
  3. Fill in all sections of the template
  4. Click "Create pull request"

πŸ› Are you fixing a bug?

  • Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • The pull request must only fix an existing bug. To contribute other changes, you must use a different template.
  • The pull request must update the test suite to demonstrate the changed functionality.
  • After you create the pull request, all status checks must be pass before a maintainer reviews your contribution.

Identify the Bug

Link to the issue describing the bug that you're fixing.

If there is not yet an issue for your bug, please open a new issue and then link to that issue in your pull request.
Note: In some cases, one person's "bug" is another person's "feature." If the pull request does not address an existing issue with the "bug" label, the maintainers have the final say on whether the current behavior is a bug.

Description of the Change

We must be able to understand the design of your change from this description. If we can't get a good idea of what the code will be doing from the description here, the pull request may be closed at the maintainers' discretion. Keep in mind that the maintainer reviewing this PR may not be familiar with or have worked with the code here recently, so please walk us through the concepts.

Alternate Designs

Explain what other alternates were considered and why the proposed version was selected

Possible Drawbacks

What are the possible side-effects or negative impacts of the code change?

Verification Process

What process did you follow to verify that the change has not introduced any regressions? Describe the actions you performed (including buttons you clicked, text you typed, commands you ran, etc.), and describe the results you observed.

Release Notes

Please describe the changes in a single line that explains this improvement in
terms that a user can understand. This text will be used in NDlib's release notes.

If this change is not user-facing or notable enough to be included in release notes
you may use the strings "Not applicable" or "N/A" here.

Examples:

  • The GitHub package now allows you to add co-authors to commits.
  • Fixed an issue where multiple cursors did not work in a file with a single line.
  • Increased the performance of searching and replacing across a whole project.

πŸ“ˆ Are you improving performances?

  • Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • The pull request must only affect performance of existing functionality. To contribute other changes, you must use a different template.
  • After you create the pull request, all status checks must be pass before a maintainer reviews your contribution.

Description of the Change

We must be able to understand the design of your change from this description. If we can't get a good idea of what the code will be doing from the description here, the pull request may be closed at the maintainers' discretion. Keep in mind that the maintainer reviewing this PR may not be familiar with or have worked with the code here recently, so please walk us through the concepts.

Quantitative Performance Benefits

Describe the exact performance improvement observed (for example, reduced time to complete an operation, reduced memory use, etc.). Describe how you measured this change. Bonus points for including graphs that demonstrate the improvement or attached dumps from the built-in profiling tools.

Possible Drawbacks

What are the possible side-effects or negative impacts of the code change?

Verification Process

What process did you follow to verify that the change has not introduced any regressions? Describe the actions you performed (including buttons you clicked, text you typed, commands you ran, etc.), and describe the results you observed.

Applicable Issues

Enter any applicable Issues here

Release Notes

Please describe the changes in a single line that explains this improvement in
terms that a user can understand. This text will be used in NDlib's release notes.

If this change is not user-facing or notable enough to be included in release notes
you may use the strings "Not applicable" or "N/A" here.

Examples:

  • The GitHub package now allows you to add co-authors to commits.
  • Fixed an issue where multiple cursors did not work in a file with a single line.
  • Increased the performance of searching and replacing across a whole project.

πŸ“ Are you updating documentation?

  • Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • The pull request must only contribute documentation (for example, markdown files or API docs). To contribute other changes, you must use a different template.

Description of the Change

We must be able to understand the purpose of your change from this description. If we can't get a good idea of the benefits of the change from the description here, the pull request may be closed at the maintainers' discretion.

Release Notes

Please describe the changes in a single line that explains this improvement in
terms that a user can understand. This text will be used in NDlib's release notes.

If this change is not user-facing or notable enough to be included in release notes
you may use the strings "Not applicable" or "N/A" here.

Examples:

  • The GitHub package now allows you to add co-authors to commits.
  • Fixed an issue where multiple cursors did not work in a file with a single line.
  • Increased the performance of searching and replacing across a whole project.

πŸ’» Are you changing functionalities?

  • Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • The pull request must contribute a change that has been endorsed by the maintainer team. See details in the template below.
  • The pull request must update the test suite to exercise the updated functionality.
  • After you create the pull request, all status checks must be pass before a maintainer reviews your contribution.

Issue or RFC Endorsed by NDlib's Maintainers

Link to the issue or RFC that your change relates to. This must be one of the following:

  • An open issue with the help-wanted label
  • An open issue with the triaged label
  • An RFC with "accepted" status

To contribute other changes, you must use a different template.

Description of the Change

We must be able to understand the design of your change from this description. If we can't get a good idea of what the code will be doing from the description here, the pull request may be closed at the maintainers' discretion. Keep in mind that the maintainer reviewing this PR may not be familiar with or have worked with the code here recently, so please walk us through the concepts.

Alternate Designs

Explain what other alternates were considered and why the proposed version was selected

Possible Drawbacks

What are the possible side-effects or negative impacts of the code change?

Verification Process

What process did you follow to verify that your change has the desired effects?

  • How did you verify that all new functionality works as expected?
  • How did you verify that all changed functionality works as expected?
  • How did you verify that the change has not introduced any regressions?

Describe the actions you performed (including buttons you clicked, text you typed, commands you ran, etc.), and describe the results you observed.

Release Notes

Please describe the changes in a single line that explains this improvement in
terms that a user can understand. This text will be used in NDlib's release notes.

If this change is not user-facing or notable enough to be included in release notes
you may use the strings "Not applicable" or "N/A" here.

Examples:

  • The GitHub package now allows you to add co-authors to commits.

  • Fixed an issue where multiple cursors did not work in a file with a single line.

  • Increased the performance of searching and replacing across a whole project.

  • The GitHub package now allows you to add co-authors to commits.

  • Fixed an issue where multiple cursors did not work in a file with a single line.

  • Increased the performance of searching and replacing across a whole project.

@lgtm-com
Copy link

lgtm-com bot commented Apr 14, 2020

This pull request introduces 3 alerts and fixes 1 when merging 48a50e9 into c1a81b1 - view on LGTM.com

new alerts:

  • 2 for Unused import
  • 1 for Except block handles 'BaseException'

fixed alerts:

  • 1 for Suspicious unused loop iteration variable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant