Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve edits1 performances #7

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

geowarin
Copy link

Hello there!

I noticed the project was based on typo-js, but the API you provide is really better.
So thank you.

When looking at typo-js, I noticed a couple of pull requests that were not merged.
A very interesting one is cfinke/Typo.js#28.

By refactoring the edits1 function, the commiter claims 10x improvements.

I decided to create a simple perf test to see if it was true.

Results:

Before edits1 modification:
231 suggestions in 77047 ms

After:
231 suggestions in 9215 ms

So that's an 8-fold improvement over the original version, without losing any suggestion.
Credit goes to @tonioloewald for his amazing work.

Another commiter claims that we can get much better performances if we do not use distance2.
According to my bench, that's indeed another 20-fold improvement but I need to run some more tests as it significantly reduces the number of suggestions.

So I'll keep you posted on my progress but this one is totally safe to merge and it really improves performance.

@FeepingCreature
Copy link

Hi, just fyi, I made a much better alternative to edit1 over here. If you're still running a fork of this lib, you may want to switch to that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants