Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there!
I noticed the project was based on typo-js, but the API you provide is really better.
So thank you.
When looking at typo-js, I noticed a couple of pull requests that were not merged.
A very interesting one is cfinke/Typo.js#28.
By refactoring the edits1 function, the commiter claims 10x improvements.
I decided to create a simple perf test to see if it was true.
Results:
So that's an 8-fold improvement over the original version, without losing any suggestion.
Credit goes to @tonioloewald for his amazing work.
Another commiter claims that we can get much better performances if we do not use distance2.
According to my bench, that's indeed another 20-fold improvement but I need to run some more tests as it significantly reduces the number of suggestions.
So I'll keep you posted on my progress but this one is totally safe to merge and it really improves performance.