Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix header offset #2812

Merged
merged 5 commits into from
Feb 6, 2025
Merged

Fix header offset #2812

merged 5 commits into from
Feb 6, 2025

Conversation

zenoachtig
Copy link
Contributor

  • Consistent use of the (renamed) site-header: and (new) site-header-sections: Tailwind variants in TOC, PageAside, and OpenAPI block
  • Fixes API response block overlapping header if it has sections

Before:
Screenshot 2025-02-06 at 11 15 56

After:
Screenshot 2025-02-06 at 11 16 54

- Consistent use of the (renamed) `site-header:` and (new) `site-header-sections` Tailwind variants in TOC, PageAside, and OpenAPI block
- Fixes API response block overlapping header if it has sections
Copy link
Contributor

github-actions bot commented Feb 6, 2025

Copy link

argos-ci bot commented Feb 6, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 👍 Changes approved 6 changed Feb 6, 2025, 1:48 PM

@nolannbiron
Copy link
Member

@zenoachtig Nice one! With small headers the block is pretty far (example), also the "On this page" TOC is going over the block, can we try to handle all those cases ?

Copy link

changeset-bot bot commented Feb 6, 2025

🦋 Changeset detected

Latest commit: 770e5f6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
gitbook Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@zenoachtig
Copy link
Contributor Author

@zenoachtig Nice one! With small headers the block is pretty far (example), also the "On this page" TOC is going over the block, can we try to handle all those cases ?

Yeah whoops, my selector was incorrect (because the page always contains a header > nav, inside the PageHeader. Fix is up and will be ready in a sec 😊

@zenoachtig zenoachtig merged commit 92b7668 into main Feb 6, 2025
12 checks passed
@zenoachtig zenoachtig deleted the fix-header-offset branch February 6, 2025 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants