Make tint color subtler when equal to primary color #2808
Merged
+127
−83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: bc5c831 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Summary of the deployments: Version 1 (production)
Version 2 (experimental)
Test content |
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
zenoachtig
changed the title
valentin0h
approved these changes
Feb 5, 2025
packages/gitbook/src/components/RootLayout/CustomizationRootLayout.tsx
Outdated
Show resolved
Hide resolved
packages/gitbook/src/components/RootLayout/CustomizationRootLayout.tsx
Outdated
Show resolved
Hide resolved
packages/gitbook/src/components/RootLayout/CustomizationRootLayout.tsx
Outdated
Show resolved
Hide resolved
packages/gitbook/src/components/RootLayout/CustomizationRootLayout.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Valentino Hudhra <2587839+valentin0h@users.noreply.github.com>
valentin0h
reviewed
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new tint colour system results in pretty intense looks when using the primary colour as the tint colour 1:1. To reduce this effect, we will add in 40% grey with the primary colour when exactly equal to the primary colour. This results in a more subtle tone.
When the tint colour is custom-set, we give control to the user and use the chosen colour exactly.