-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only push scrolling down when Footer is present #2807
Conversation
🦋 Changeset detectedLatest commit: 8d478dc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Summary of the deployments: Version 1 (production)
Version 2 (experimental)
Test content |
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Might want to check if this works well with #2805 still, both of which will hopefully merge today |
Not sure if it's intentional or not but something changed with the 404 pages on small screens, they were displayed centered before and now they're aligned top: https://app.argos-ci.com/GitbookIO/gitbook/builds/2255/135184281 |
yep, saw that. I was gonna wait to check your PR first in case this one is no longer relevant. |
This fixes vertical scrolling when there is no Footer below the content to see by conditionally adding the extra height. The screen was scrolling unnecessarily when the footer wasn't present. This makes sure that there is no scrolling when the footer is not present and the content does not go beyond the screen size.
Before:
Screen.Recording.2025-02-04.at.14.16.30.mov
After:
Screen.Recording.2025-02-04.at.14.50.24.mov