Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only push scrolling down when Footer is present #2807

Merged
merged 7 commits into from
Feb 5, 2025

Conversation

scazan
Copy link
Contributor

@scazan scazan commented Feb 4, 2025

This fixes vertical scrolling when there is no Footer below the content to see by conditionally adding the extra height. The screen was scrolling unnecessarily when the footer wasn't present. This makes sure that there is no scrolling when the footer is not present and the content does not go beyond the screen size.

Before:

Screen.Recording.2025-02-04.at.14.16.30.mov

After:

Screen.Recording.2025-02-04.at.14.50.24.mov

Copy link

changeset-bot bot commented Feb 4, 2025

🦋 Changeset detected

Latest commit: 8d478dc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
gitbook Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@scazan scazan marked this pull request as ready for review February 4, 2025 13:22
Copy link
Contributor

github-actions bot commented Feb 4, 2025

Copy link

argos-ci bot commented Feb 4, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 👍 Changes approved 73 changed Feb 5, 2025, 11:24 AM

@zenoachtig
Copy link
Contributor

Might want to check if this works well with #2805 still, both of which will hopefully merge today

@zenoachtig
Copy link
Contributor

Not sure if it's intentional or not but something changed with the 404 pages on small screens, they were displayed centered before and now they're aligned top: https://app.argos-ci.com/GitbookIO/gitbook/builds/2255/135184281

@scazan
Copy link
Contributor Author

scazan commented Feb 4, 2025

Not sure if it's intentional or not but something changed with the 404 pages on small screens, they were displayed centered before and now they're aligned top: https://app.argos-ci.com/GitbookIO/gitbook/builds/2255/135184281

yep, saw that. I was gonna wait to check your PR first in case this one is no longer relevant.

@scazan scazan merged commit d935fb1 into main Feb 5, 2025
11 of 12 checks passed
@scazan scazan deleted the scottcazan/removeScrollWhenNoFooter branch February 5, 2025 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants