Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RND-5646: section groups navigation menu #2789

Merged
merged 20 commits into from
Feb 4, 2025

Conversation

BrettJephson
Copy link
Contributor

@BrettJephson BrettJephson commented Jan 30, 2025

This change adds grouped sections.

section-groups-screenshot

Horizontal section list:

CleanShot.2025-02-03.at.15.16.36.mp4

Vertical list:

CleanShot.2025-01-31.at.10.50.53.mp4

@BrettJephson BrettJephson self-assigned this Jan 30, 2025
Copy link

linear bot commented Jan 30, 2025

Copy link

changeset-bot bot commented Jan 30, 2025

🦋 Changeset detected

Latest commit: d6cbc9d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
gitbook Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@BrettJephson BrettJephson force-pushed the brett/RND-5646-section-group-dropdown branch 2 times, most recently from 3da4cd7 to 73ac484 Compare January 30, 2025 13:50
Copy link
Contributor

github-actions bot commented Jan 30, 2025

GitBook Preview
Latest commit: https://28ac2649.gitbook-open.pages.dev
PR: https://pr2789.gitbook-open.pages.dev

Copy link

argos-ci bot commented Jan 30, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 👍 Changes approved 64 changed Feb 4, 2025, 4:37 PM

@BrettJephson BrettJephson marked this pull request as ready for review January 31, 2025 10:08
Copy link
Contributor

github-actions bot commented Jan 31, 2025

@BrettJephson BrettJephson force-pushed the brett/RND-5646-section-group-dropdown branch from f906c38 to d376e4e Compare February 3, 2025 13:24
@BrettJephson BrettJephson force-pushed the brett/RND-5646-section-group-dropdown branch from 9b709d8 to a6a288a Compare February 4, 2025 15:36
Copy link
Contributor

@emmerich emmerich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to test the preview deployment on the docs we know using sections to ensure we haven't caused regressions

packages/gitbook/src/lib/api.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@emmerich emmerich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to see a visual test or two for the new UI

@BrettJephson
Copy link
Contributor Author

Will add visual regression tests for sections and section groups in a separate PR.

@BrettJephson BrettJephson merged commit 38061bd into main Feb 4, 2025
12 checks passed
@BrettJephson BrettJephson deleted the brett/RND-5646-section-group-dropdown branch February 4, 2025 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants