Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Init improvements #532

Merged
merged 5 commits into from
Jul 23, 2015
Merged

Init improvements #532

merged 5 commits into from
Jul 23, 2015

Conversation

JakeGinnivan
Copy link
Contributor

No description provided.

@JakeGinnivan
Fixed some urls in exceptions
27d0f8e
@JakeGinnivan
Moved defaulting config out of the ctor of Config class and into Conf…
bcca05f 
…igurationProvider

This allows a new empty instance of the config to be spun up. It also means all the defaulting logic and values are in a similar place rather than spread around the codebase
@JakeGinnivan
Enabled init steps to be tested
be56c48
@JakeGinnivan
Fixed failing test
90808bd
@JakeGinnivan
Wrote example test for init
2c900df
@JakeGinnivan
Copy link
Contributor Author

Fixed #514

JakeGinnivan added a commit that referenced this pull request Jul 23, 2015
@JakeGinnivan
Merge pull request #532 from JakeGinnivan/InitImprovements
96060dc 
Init improvements
@JakeGinnivan JakeGinnivan merged commit 96060dc into GitTools:master Jul 23, 2015
@JakeGinnivan JakeGinnivan deleted the InitImprovements branch July 23, 2015 08:24
@veccie veccie mentioned this pull request Jul 28, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JakeGinnivan