TagPrefix cleanup #510
Merged
TagPrefix cleanup #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at resulted from a partial merge of pull request. More specifically TagPrefix is always considered optional.
|
@SimonCropp this PR seems to be causing a PEVerify error. https://ci.appveyor.com/project/GitTools/gitversion/build/0.0.60#L204 Any ideas? Wondering if it's the const? |
|
I'm seeing the error on my side with a solution rebuild. If I remove the const it does indeed go away. There's a bit more info in the error: @JakeGinnivan Would you rather me just rid the const and hardcode the "[vV]" as it was? |
…ternal to circumvent a PE Validation error: GitVersion.Config::DebuggerDisplay][offset 0x00000026] Unable to resolve token.(Error: 0x80131869) occurs due to "public const".
|
I updated the branch to use an |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaning up a few leftovers that resulted from a partial merge of pull request #496. As before, TagPrefix is always considered optional.