Refactor GitVersion.Core for clear, maintainable methods #3804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit refactors several methods within GitVersion.Core and its associated test files for better clarity and maintainability. Apart from renaming variables for clearer intent, it also streamlines the use of JsonSerializerOptions and simplifies the use of the 'toJson' method throughout the codebase. Moreover, it adjusts the accessibility of certain methods, modifying them from public to internal where appropriate.
|
Thank you @arturcic for your contribution! |
arturcic
added a commit
to arturcic/GitVersion
that referenced
this pull request
Nov 29, 2023
Refactor GitVersion.Core for clear, maintainable methods
|
🎉 This issue has been resolved in version 6.0.0-beta.4 🎉 Your GitReleaseManager bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit refactors several methods within GitVersion.Core and its associated test files for better clarity and maintainability. Apart from renaming variables for clearer intent, it also streamlines the use of JsonSerializerOptions and simplifies the use of the 'toJson' method throughout the codebase. Moreover, it adjusts the accessibility of certain methods, modifying them from public to internal where appropriate.