Allow develop branch name to be configured #306
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeGinnivan
changed the title
|
@JakeGinnivan can you fix up this log message as well: This will be incorrect if someone chooses to alter the configuration. |
| Assert.IsTrue(new MockBranch("develop").IsDevelop()); | ||
| Assert.IsTrue(new MockBranch("Develop").IsDevelop()); | ||
| Assert.IsFalse(new MockBranch("hotfix1").IsDevelop()); | ||
| Assert.IsTrue(new MockBranch("develop").IsDevelop(new Config())); |
There was a problem hiding this comment.
Do we need another set of tests here to test when a configured name is being used for the develop branch that IsDevelop still works?
|
@JakeGinnivan If we are going to do this for the develop branch, I think that it would make sense to do it for all configurable branch names, i.e. master, release, hotfix, support, etc. However, these can be done as separate PR's if you are in agreement. |
|
After discussions in #292, not going to do this at the moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #292