Fix for the wrong updateBuildNumber behavior #2457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `updateBuildNumber` is set to false the Build Number is still be overwritten.
|
@arturcic I am not sure about the tests. Is it ok to have them that way? |
arturcic
approved these changes
Nov 17, 2020
|
@kirkone thank you so much for your contributions 👍 |
|
🎉 This issue has been resolved in version 5.6.0 🎉 Your GitReleaseManager bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
updateBuildNumberis set to false the Build Number is still be overwritten.Description
As discussed in #1770 the switch should result in a different behavior.
Related Issue
#1457
#1770
Motivation and Context
The behavior was not implemented in the way it was intended. This should fix this.
How Has This Been Tested?
Tested on my local machine and in my own Azure DevOps instance.
Checklist: