-
Notifications
You must be signed in to change notification settings - Fork 649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
should get exact version from tag #211
Conversation
@andreasohlund @JakeGinnivan @distantcam does this look like a valid unit test? |
Looks right to me |
"Number": 2 | ||
}, | ||
"BuildMetaData": { | ||
"CommitsSinceTag": 1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be 0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It probably should be.. I think the wiki is wrong in this regard sigh
Thoughts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@distantcam @JakeGinnivan issue raised here #213
note this is only for GV. fixed by @distantcam for GHF in this commit dd63885 |
@JakeGinnivan @distantcam @andreasohlund code review is anyone has time |
should get exact version from tag
No description provided.