-
Notifications
You must be signed in to change notification settings - Fork 649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamic repo should require a branch specified #367
Comments
I will pick this up and send a PR soon. Ideally I would like a discussion around the PR before it's merged. I will put my concerns on the PR. |
Oops :P didn't read before I merged |
What were the concerns? Or ended up being ok? |
They were more around the fact that we're throwing the base class On 15 July 2015 at 23:00, Jake Ginnivan notifications@github.com wrote:
|
The exception handling isn't great. No plan, but no objections to fix it up |
Excellent. I will create an issue for this so that I don't forget. I will On 16 July 2015 at 00:10, Jake Ginnivan notifications@github.com wrote:
|
See #351 (comment)
When using the https://github.com/ParticularLabs/GitVersion/wiki/Feature:-Dynamically-Obtained-Repository feature (
/url
) we should throw if the/b
argument is not used. The exception should contain information from that wiki page to make it easy for people to know what is going wrong.The text was updated successfully, but these errors were encountered: