Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic repo should require a branch specified #367

Closed
JakeGinnivan opened this issue Feb 15, 2015 · 6 comments
Closed

Dynamic repo should require a branch specified #367

JakeGinnivan opened this issue Feb 15, 2015 · 6 comments

Comments

@JakeGinnivan
Copy link
Contributor

See #351 (comment)

When using the https://github.com/ParticularLabs/GitVersion/wiki/Feature:-Dynamically-Obtained-Repository feature (/url) we should throw if the /b argument is not used. The exception should contain information from that wiki page to make it easy for people to know what is going wrong.

@RaphHaddad
Copy link
Contributor

I will pick this up and send a PR soon.

Ideally I would like a discussion around the PR before it's merged. I will put my concerns on the PR.

JakeGinnivan added a commit that referenced this issue Jul 15, 2015
@JakeGinnivan
Copy link
Contributor Author

Oops :P didn't read before I merged

@JakeGinnivan
Copy link
Contributor Author

What were the concerns? Or ended up being ok?

@RaphHaddad
Copy link
Contributor

They were more around the fact that we're throwing the base class
'Exception' everywhere. Is there any plan to have our own derived
Exceptions?

On 15 July 2015 at 23:00, Jake Ginnivan notifications@github.com wrote:

What were the concerns? Or ended up being ok?


Reply to this email directly or view it on GitHub
#367 (comment)
.

@JakeGinnivan
Copy link
Contributor Author

The exception handling isn't great. No plan, but no objections to fix it up

@RaphHaddad
Copy link
Contributor

Excellent. I will create an issue for this so that I don't forget. I will
get on this in the next few days.

On 16 July 2015 at 00:10, Jake Ginnivan notifications@github.com wrote:

The exception handling isn't great. No plan, but no objections to fix it up


Reply to this email directly or view it on GitHub
#367 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants