Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] GitVersion forces a C# language for projects that aren't C# #3654

Closed
baronfel opened this issue Aug 16, 2023 · 1 comment · Fixed by #3701
Closed

[Bug] GitVersion forces a C# language for projects that aren't C# #3654

baronfel opened this issue Aug 16, 2023 · 1 comment · Fixed by #3701
Labels
bug
Milestone
6.0.0-beta.4

Comments

@baronfel
Copy link

Describe the bug

There's a detailed investigation in dotnet/project-system#9012, but the gist is that since GitVersion forces a C# language it introduces bugs in F# builds.

Expected Behavior

Design-time builds work for F# projects

Actual Behavior

Design-time builds crash for F# projects

Possible Fix

Can this line be removed?

Steps to Reproduce

See the linked issue
@baronfel baronfel added the bug label Aug 16, 2023
abatishchev added a commit to abatishchev/GitVersion that referenced this issue Sep 28, 2023
@abatishchev
Removed setting Language=C# from GitVersion.MsBuild.props
f196981 
Resolves GitTools#3654.

Rationale: GitVersion should not force C# language for projects that aren't C#, such as F# or generic *.msbuildproject.
@abatishchev abatishchev mentioned this issue Sep 28, 2023
Merged
5 tasks
abatishchev added a commit to abatishchev/GitVersion that referenced this issue Sep 28, 2023
@abatishchev
Removed setting Language=C# from GitVersion.MsBuild.props
8318dd4 
Resolves GitTools#3654.

Rationale: GitVersion should not force C# language for projects that aren't C#, such as F# or generic *.msbuildproject.
@arturcic arturcic added this to the 6.x milestone Sep 29, 2023
@arturcic arturcic modified the milestones: 6.x, 6.0.0-beta.4 Dec 12, 2023
@arturcic
Copy link
Member

🎉 This issue has been resolved in version 6.0.0-beta.4 🎉
The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
6.0.0-beta.4
Development

Successfully merging a pull request may close this issue.

Removed setting Language=C# from GitVersion.MsBuild.props abatishchev/GitVersion
2 participants
@baronfel @arturcic