Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate warning about Yaml file not being found is being shown #513

Closed
gep13 opened this issue Aug 22, 2023 · 2 comments
Closed

Duplicate warning about Yaml file not being found is being shown #513

gep13 opened this issue Aug 22, 2023 · 2 comments
Labels
Milestone

Comments

@gep13
Copy link
Member

gep13 commented Aug 22, 2023

Description

Duplicate warning about Yaml file not being found is being shown.

Expected Behavior

Warning should only be shown once.

Actual Behavior

Warning is shown twice

Possible Fix

Not sure at this point in time.

Steps to Reproduce

Run the command:

.\GitReleaseManager.exe showconfig

Context

This isn't a showstopper bug, but definitely one that should be addressed.

Your Environment

N/A

@gep13
Copy link
Member Author

gep13 commented Aug 22, 2023

image

gep13 added a commit that referenced this issue Aug 24, 2023
When calling the showconfig command, it was re-hydrating the
configuration file from disk, rather than using the existing
configuration from the IoC container.

This commit changes the associated methods to re-use the existing
Config object, rather than creating it again from scratch.  This has
the result of only showing the Warning about a missing Yaml file once,
and not twice.
@gep13 gep13 added this to the 0.16.0 milestone Aug 24, 2023
@gep13 gep13 closed this as completed Aug 24, 2023
gittools-bot pushed a commit that referenced this issue Aug 24, 2023
(#513) Re-use existing Config from container

When calling the showconfig command, it was re-hydrating the
configuration file from disk, rather than using the existing
configuration from the IoC container.

This commit changes the associated methods to re-use the existing
Config object, rather than creating it again from scratch.  This has
the result of only showing the Warning about a missing Yaml file once,
and not twice.
@gittools-bot
Copy link
Contributor

🎉 This issue has been resolved in version 0.16.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants