Skip to content
This repository has been archived by the owner on Feb 12, 2023. It is now read-only.

Relative path parameter doesn't work #44

Closed
tpluscode opened this issue Nov 8, 2014 · 10 comments
Closed

Relative path parameter doesn't work #44

tpluscode opened this issue Nov 8, 2014 · 10 comments
Assignees
Milestone

Comments

@tpluscode
Copy link
Contributor

Hi

Here's how I run GitLink in my solution

$(MSBuildProjectDirectory)\Build\GitLink.exe" "$(MSBuildProjectDirectory)\.." -u https://github.com/r2rml4net/core

Apparently the .. path segment doesn't work for some reason.

I've fixed this by wrapping the path in $([System.IO.Path]::GetFullPath(..)) but it looks like a bug.

Tom

@GeertvanHorrik
Copy link
Contributor

Good find. Will add this code.

@GeertvanHorrik GeertvanHorrik added this to the 2.1.0 milestone Nov 9, 2014
GeertvanHorrik added a commit that referenced this issue Nov 9, 2014
@GeertvanHorrik GeertvanHorrik self-assigned this Nov 9, 2014
@GeertvanHorrik
Copy link
Contributor

Prerelease version with fix has been deployed.

@tpluscode
Copy link
Contributor Author

Thanks. The NuGet package doesn't add a reference anymore, does it? In such case could you change it so that the exe sits in net20 folder. Currently I got an error saying I can't install the package becuase it targets only .NET 4.5.

@tpluscode
Copy link
Contributor Author

Hm, I replaced the exe and the build server failed with exception [TypeInitializationException] System.TypeInitializationException: The type initializer for 'LibGit2Sharp.Core.NativeMethods' threw an exception. ---> System.DllNotFoundException: Unable to load DLL 'git2-3f8d005'

Why is that?

@GeertvanHorrik
Copy link
Contributor

My screw up, I have to replace the embedded libs every time I update the libgit2sharp package. Just released a fix.

@tpluscode
Copy link
Contributor Author

And what about the NuGet pacakge requirement for net45? Is that necessary?

@GeertvanHorrik
Copy link
Contributor

Not sure. You can reference the executable as a regular library and use it if you need it. That doesn't work anymore?

@tpluscode
Copy link
Contributor Author

It sure works when I simply drop it in a tools folder and run from msbuild (I use the <Exec /> task).

But installing from NuGet fails because I target .NET 4.0 and the package only contains a net45 folder.

@tpluscode
Copy link
Contributor Author

I've created a new issue for my NuGet questions.

And of course the new GitLink.exe works fine with relative paths.

@GeertvanHorrik
Copy link
Contributor

Thanks, we will keep this issue closed and continue on the other one.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants