Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the Firebase Android BoM to manage Firebase library versions. #28

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Added the Firebase Android BoM to manage Firebase library versions. #28

merged 1 commit into from
Sep 4, 2024

Conversation

siarhei-luskanau
Copy link
Contributor

No description provided.

@siarhei-luskanau siarhei-luskanau changed the title Added the Firebase Android BoM (Bill of Materials) enables you to manage all your Firebase library versions. Added the Firebase Android BoM (Bill of Materials) to manage all your Firebase library versions. Sep 1, 2024
@siarhei-luskanau siarhei-luskanau changed the title Added the Firebase Android BoM (Bill of Materials) to manage all your Firebase library versions. Added the Firebase Android BoM to manage all your Firebase library versions. Sep 1, 2024
@siarhei-luskanau siarhei-luskanau changed the title Added the Firebase Android BoM to manage all your Firebase library versions. Added the Firebase Android BoM to manage Firebase library versions. Sep 1, 2024
@siarhei-luskanau
Copy link
Contributor Author

@nbransby Would you like to review this PR?

@nbransby
Copy link
Member

nbransby commented Sep 4, 2024

Changing the firebase library versions is not trivial as its unlikely to prevent the build succeeding but very likely to cause crashes at runtime, I assume you added getThread to fix one of thoses crashes - problem is the test coverage is not currently high enough to catch all likely crashes without additional manual testing.

One possible solution would be to merge this in and do an alpha release to crowdsource the testing.

@siarhei-luskanau
Copy link
Contributor Author

Changing the firebase library versions is not trivial as its unlikely to prevent the build succeeding but very likely to cause crashes at runtime, I assume you added getThread to fix one of thoses crashes - problem is the test coverage is not currently high enough to catch all likely crashes without additional manual testing.

One possible solution would be to merge this in and do an alpha release to crowdsource the testing.

Thank you for response. You are right, this changes aren't tested at runtime.
I propose use tested version of Firebase BoM 32.7.0.

And next step can be alpha release with the latest Firebase BoM version

@nbransby
Copy link
Member

nbransby commented Sep 4, 2024

Are all the Firebase BoM 32.7.0 versions equal to or less than the one we specified before this PR?

@siarhei-luskanau
Copy link
Contributor Author

Are all the Firebase BoM 32.7.0 versions equal to or less than the one we specified before this PR?

Yes. The Firebase libraries version are listed in POM file https://dl.google.com/android/maven2/com/google/firebase/firebase-bom/32.7.0/firebase-bom-32.7.0.pom

All firebase-bom versions can be found at https://maven.google.com/web/index.html?q=bom#com.google.firebase:firebase-bom

@nbransby
Copy link
Member

nbransby commented Sep 4, 2024

would be a lot easier to see whats changes after a review if you didn't force push all the time ;)

@nbransby nbransby merged commit 482e35b into GitLiveApp:master Sep 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants