Fixing pdm lock running forever, and cleaning up some files #1388
Conversation
| @@ -54,7 +55,7 @@ dev = [ | |||
| "pytest-xdist>=3.3.1", | |||
| "ruff>=0.0.271", | |||
| "mlflow>2", | |||
| "black[d]>=22.12.0", | |||
There was a problem hiding this comment.
blackd is used by intellij, it runs as a server and then intellij will call it every time you need to run reformatting.
black[jupyter] doesn't ship blackd command utility
There was a problem hiding this comment.
I will put it back then 👍
Hartorn
force-pushed
the
fix/repair-lock-generation
branch
from
7bf1153 to
e567278
Compare
python-client/pyproject.toml
Outdated
| @@ -71,8 +72,9 @@ test = [ | |||
| "tensorflow-macos>=2.10.0, <2.11; sys_platform == 'darwin' and platform_machine == 'arm64'", | |||
| "tensorflow>=2.10.0, <2.11; sys_platform != 'darwin' or platform_machine != 'arm64'", | |||
| "tensorflow-text>=2.10.0, <2.11; platform_machine == 'x86_64' or platform_machine == 'amd64'", | |||
| "mlflow>2", | |||
| "wandb" | |||
| "mlflow>2", # Should it be somewhere else ? | |||
There was a problem hiding this comment.
actually I don't know why we install a full mlflow in dev mode while mlflow-skinny being part of prod dependencies, maybe @rabah-khalek knows
There was a problem hiding this comment.
mlflow.evaluate() (where we implemented our plug-in) is not shipped with mlflow-skinny. It is needed for functional tests of the plugin.
python-client/pyproject.toml
Outdated
| "mlflow>2", | ||
| "wandb" | ||
| "mlflow>2", # Should it be somewhere else ? | ||
| "wandb", # Should it be somewhere else ? |
There was a problem hiding this comment.
no it's an optional dependency that we'll ask users to install if they try to use W&B integration.
We install it for tests because there are unit tests for it
There was a problem hiding this comment.
I will remove comment then
Hartorn
force-pushed
the
fix/repair-lock-generation
branch
from
e567278 to
b9d0987
Compare
| "mypy>=0.982", | ||
| "deptry>=0.5.13", | ||
| "httpretty>=1.1.4", |
There was a problem hiding this comment.
was it deptry who sugested the removal?
There was a problem hiding this comment.
No, this one I checked it manually I think.
I used deptry, but I also had a look around on deps to see if some were unused.
python-client/pyproject.toml
Outdated
| @@ -72,7 +73,8 @@ test = [ | |||
| "tensorflow>=2.10.0, <2.11; sys_platform != 'darwin' or platform_machine != 'arm64'", | |||
| "tensorflow-text>=2.10.0, <2.11; platform_machine == 'x86_64' or platform_machine == 'amd64'", | |||
| "mlflow>2", | |||
| "wandb" | |||
| "wandb", | |||
| "tensorflow-io-gcs-filesystem==0.27.0", # Transitive dependency, needed to make it work for windows (downgrade from 0.33 to 0.27) | |||
There was a problem hiding this comment.
should we add sys_platform marker in this case? And let other OS users install more recent versions?
There was a problem hiding this comment.
otherwise we'll be stuck with python <3.11 forever
There was a problem hiding this comment.
Well, this version is the recommended one according to https://github.com/tensorflow/io
I checked the matrix there, that's why I fixed it.
Honestly, we'll need to make changes to every tf package to handle 3.11 after.
There was a problem hiding this comment.
could you also tell what exactly breaks on windows with more recent versions of tensorflow-io-gcs-filesystem ?
There was a problem hiding this comment.
Basically, it cannot be installed. It's trying to find a version, but cannot find one matching the needed requirements.
I cannot find the build error anymore, I must have deleted them while cleaning yesterday.
I checked a bit into the lock file, and from I can see, there is not wheel registeres for 0.33 for win os.
I will try to change again, I will see if it's still broken
There was a problem hiding this comment.
OK, I reproduced it in here : #1389
https://github.com/Giskard-AI/giskard/actions/runs/6120611136/job/16612786445?pr=1389
And I found the root cause :
Basically, since 0.32, there is no win wheel on pipy, I will see this afternoon for the details.
0.31 should work though
Hartorn
force-pushed
the
fix/repair-lock-generation
branch
from
b9d0987 to
6e25d4b
Compare
Hartorn
force-pushed
the
fix/repair-lock-generation
branch
from
6e25d4b to
fe6a41e
Compare
Description
Atm, when trying to run
pdm lock -G :all, it will not workIt's mainly beacause of
safetypackage, which depends onpackaging<22.0,>=21.0For exemple,
blackversion 23.7 depends on packaging > 22Also, trying to keep version 3.11 of python handled seems to be problematic
Related Issue
Type of Change
Checklist
CODE_OF_CONDUCT.mddocument.CONTRIBUTING.mdguide.make codestyle.