Merge pull request #2071 from Giskard-AI/2061-test-output-in-range-in…

…dexing-error-while-using-slicing-function-for-classification-problem Fixed boolean indexer mismatching issue
Giskard-AI · Nov 12, 2024 · 8e2fac6 · 8e2fac6
2 parents 1cde456 + 0b23355
commit 8e2fac6
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 3 deletions.
diff --git a/.github/workflows/build-python.yml b/.github/workflows/build-python.yml
@@ -120,6 +120,7 @@ jobs:
         uses: pdm-project/setup-pdm@v4
         with:
           python-version: ${{ matrix.python-version }}
+          version: head # Issue with PDM 2.20.1: https://github.com/pdm-project/pdm/issues/3271
           cache: false
 
       - name: Cache Giskard test resources
@@ -251,6 +252,7 @@ jobs:
         uses: pdm-project/setup-pdm@v4
         with:
           python-version: "3.10"
+          version: head # Issue with PDM 2.20.1: https://github.com/pdm-project/pdm/issues/3271
           cache: false
       - name: Build wheel
         run: pdm build
@@ -273,6 +275,7 @@ jobs:
         uses: pdm-project/setup-pdm@v4
         with:
           python-version: "3.10"
+          version: head # Issue with PDM 2.20.1: https://github.com/pdm-project/pdm/issues/3271
           cache: false
       - name: Build wheel
         run: pdm build
@@ -292,15 +295,15 @@ jobs:
         uses: pdm-project/setup-pdm@v4
         with:
           python-version: "3.10"
-          version: "2.10.4" # Fix to repair the CI, use latest version when fixed on pdm
+          version: head # Issue with PDM 2.20.1: https://github.com/pdm-project/pdm/issues/3271
           cache: false
       - name: Build wheel
         run: pdm build
       - name: Create new project, install wheel and import (PDM)
         run: |
           mkdir ./install-run
           cd ./install-run
-          pdm init --python 3.10 -n .
+          pdm init --python 3.10 -n
           sed -i 's/^\(requires-python *= *\).*$/\1">=3.10,<3.12"/' pyproject.toml
           pdm add "$(ls ../dist/*.whl)"
           pdm run python -c "import giskard"
@@ -336,6 +339,7 @@ jobs:
         uses: pdm-project/setup-pdm@v4
         with:
           python-version: "3.10"
+          version: head # Issue with PDM 2.20.1: https://github.com/pdm-project/pdm/issues/3271
           cache: false
 
       - name: Set up Pandoc (needed for doc)

diff --git a/.github/workflows/create-release.yml b/.github/workflows/create-release.yml
@@ -52,6 +52,7 @@ jobs:
         uses: pdm-project/setup-pdm@v4
         with:
           python-version: '3.10'
+          version: head # Issue with PDM 2.20.1: https://github.com/pdm-project/pdm/issues/3271
           cache: false
 
       - name: "@slack Release process started"

diff --git a/.github/workflows/lock-deps.yml b/.github/workflows/lock-deps.yml
@@ -55,6 +55,7 @@ jobs:
         uses: pdm-project/setup-pdm@v4
         with:
           python-version: "3.10"
+          version: head # Issue with PDM 2.20.1: https://github.com/pdm-project/pdm/issues/3271
           cache: false
 
       - name: Install dependencies

diff --git a/giskard/testing/tests/statistic.py b/giskard/testing/tests/statistic.py
@@ -145,7 +145,7 @@ def test_output_in_range(
         output = prediction_results.raw_prediction
 
     elif model.is_classification:
-        output = prediction_results.all_predictions[classification_label]
+        output = prediction_results.all_predictions[classification_label].values
 
     else:
         raise ValueError(f"Prediction task is not supported: {model.meta.model_type}")