Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition debugger to SEDAP #333

Merged
merged 13 commits into from
Feb 7, 2025
Merged

Transition debugger to SEDAP #333

merged 13 commits into from
Feb 7, 2025

Conversation

NatKarmios
Copy link
Contributor

@NatKarmios NatKarmios commented Feb 6, 2025

It's SEDAP time!

Main changes include:

  • Use ocaml-sedap instead of ocaml-dap
  • Reconfigure debugger to send SEDAP information; in particular:
    • Only send changed nodes on update, instead of sending everything every update
    • Match maps are sent alongside exec maps in the same format
  • Remove debug-ui; the Gillian debugger extension now lives in the SEDAP-JS repo

Due to the debug extension now being out of scope of the repo, this PR resolves #110, #173, #177, #181, #194, #233, #269, #281, #286

N1ark
N1ark previously approved these changes Feb 6, 2025
Copy link
Contributor

@N1ark N1ark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me :) there's some repetition between the lifters for C2 and WISL but I imagine we can't do much about that bc of different types?

Gillian.code-workspace Outdated Show resolved Hide resolved
GillianCore/logging/log_database.ml Outdated Show resolved Hide resolved
@NatKarmios
Copy link
Contributor Author

looks good to me :) there's some repetition between the lifters for C2 and WISL but I imagine we can't do much about that bc of different types?

Yes, the lifters are extremely similar, but factoring things out there felt like over-optimising. This might change if/when we have a JS lifter since that might be similar too.

N1ark
N1ark previously approved these changes Feb 6, 2025
Copy link
Contributor

@N1ark N1ark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so cool!

@NatKarmios NatKarmios merged commit d52b2ae into master Feb 7, 2025
9 checks passed
@NatKarmios NatKarmios deleted the nat/sedap branch February 7, 2025 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment