-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transition debugger to SEDAP #333
Conversation
This has been moved to the sedap-js repo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me :) there's some repetition between the lifters for C2 and WISL but I imagine we can't do much about that bc of different types?
Yes, the lifters are extremely similar, but factoring things out there felt like over-optimising. This might change if/when we have a JS lifter since that might be similar too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so cool!
It's SEDAP time!
Main changes include:
ocaml-sedap
instead ofocaml-dap
debug-ui
; the Gillian debugger extension now lives in the SEDAP-JS repoDue to the debug extension now being out of scope of the repo, this PR resolves #110, #173, #177, #181, #194, #233, #269, #281, #286