Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust catch-up #273

Merged
merged 44 commits into from
Dec 12, 2023
Merged

Rust catch-up #273

merged 44 commits into from
Dec 12, 2023

Conversation

giltho
Copy link
Contributor

@giltho giltho commented Nov 30, 2023

Many things here:

  1. Adds the magic wand operator the Asrt.t, and the Package operations, which creates a magic wand from the current state.
  2. Implements aggregate unification plans (or master unification plans), revamping a big part of UP.ml
  3. Adds implication to the formula language, which can be encoded as such to z3
  4. Replace get/set/rem by consumers and consumers, fixes Consumers and producers shouldn't be actions #225
  5. Adds support for list_repeat operator

Not everything should be merged possibly, let's trim some useless prints etc

Signed-off-by: Sacha Ayoun <sachaayoun@gmail.com>
Signed-off-by: Sacha Ayoun <sachaayoun@gmail.com>
Signed-off-by: Sacha Ayoun <sachaayoun@gmail.com>
Signed-off-by: Sacha Ayoun <sachaayoun@gmail.com>
Signed-off-by: Sacha Ayoun <sachaayoun@gmail.com>
Signed-off-by: Sacha Ayoun <sachaayoun@gmail.com>
Signed-off-by: Sacha Ayoun <sachaayoun@gmail.com>
Signed-off-by: Sacha Ayoun <sachaayoun@gmail.com>
Signed-off-by: Sacha Ayoun <sachaayoun@gmail.com>
Signed-off-by: Sacha Ayoun <sachaayoun@gmail.com>
Signed-off-by: Sacha Ayoun <sachaayoun@gmail.com>
Signed-off-by: Sacha Ayoun <sachaayoun@gmail.com>
Signed-off-by: Sacha Ayoun <sachaayoun@gmail.com>
Signed-off-by: Sacha Ayoun <sachaayoun@gmail.com>
Signed-off-by: Sacha Ayoun <sachaayoun@gmail.com>
Signed-off-by: Sacha Ayoun <sachaayoun@gmail.com>
Signed-off-by: Sacha Ayoun <sachaayoun@gmail.com>
Signed-off-by: Sacha Ayoun <sachaayoun@gmail.com>
Signed-off-by: Sacha Ayoun <sachaayoun@gmail.com>
Signed-off-by: Sacha Ayoun <sachaayoun@gmail.com>
Signed-off-by: Sacha Ayoun <sachaayoun@gmail.com>
Signed-off-by: Sacha Ayoun <sachaayoun@gmail.com>
Signed-off-by: Sacha Ayoun <sachaayoun@gmail.com>
Signed-off-by: Sacha Ayoun <sachaayoun@gmail.com>
Signed-off-by: Sacha Ayoun <sachaayoun@gmail.com>
Signed-off-by: Sacha Ayoun <sachaayoun@gmail.com>
Signed-off-by: Sacha Ayoun <sachaayoun@gmail.com>
Signed-off-by: Sacha Ayoun <sachaayoun@gmail.com>
Signed-off-by: Sacha Ayoun <sachaayoun@gmail.com>
giltho added 11 commits November 1, 2023 14:31
Signed-off-by: Sacha Ayoun <sachaayoun@gmail.com>
This reverts commit 6730699.
Signed-off-by: Sacha Ayoun <sachaayoun@gmail.com>
Signed-off-by: Sacha Ayoun <sachaayoun@gmail.com>
Signed-off-by: Sacha Ayoun <sachaayoun@gmail.com>
Signed-off-by: Sacha Ayoun <sachaayoun@gmail.com>
@giltho
Copy link
Contributor Author

giltho commented Dec 12, 2023

@NatKarmios This can now be reviewed and debugger can be tested independently of the CI passing if it's because of the z3 flakiness

Signed-off-by: Sacha Ayoun <sachaayoun@gmail.com>
@giltho giltho requested a review from NatKarmios December 12, 2023 13:58
Copy link
Contributor

@NatKarmios NatKarmios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just checking debugger still works.

Copy link
Contributor

@NatKarmios NatKarmios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, debugger looks good

@giltho giltho merged commit c7bbb9e into master Dec 12, 2023
9 checks passed
@giltho giltho deleted the magic-wand branch December 12, 2023 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consumers and producers shouldn't be actions
2 participants