Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit Testing for NormalApprox Analyze & Flag Functions #896

Merged
merged 2 commits into from
Nov 22, 2022
Merged

Unit Testing for NormalApprox Analyze & Flag Functions #896

merged 2 commits into from
Nov 22, 2022

Conversation

collleenmclaughlin
Copy link
Contributor

@collleenmclaughlin collleenmclaughlin commented Nov 21, 2022 •
edited
Loading

Fix #876

@collleenmclaughlin collleenmclaughlin self-assigned this Nov 21, 2022
@collleenmclaughlin collleenmclaughlin added this to the v1.4.0 milestone Nov 21, 2022
mattroumaya
mattroumaya approved these changes Nov 22, 2022
View reviewed changes
Copy link
Contributor

@mattroumaya mattroumaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @collleenmclaughlin!

@mattroumaya mattroumaya marked this pull request as ready for review November 22, 2022 16:14
@mattroumaya mattroumaya merged commit caf73e0 into dev Nov 22, 2022
@mattroumaya mattroumaya deleted the fix-876 branch November 22, 2022 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattroumaya mattroumaya mattroumaya approved these changes

Assignees

@collleenmclaughlin collleenmclaughlin

Labels
None yet
Projects
None yet
Milestone
v1.4.0
Development

Successfully merging this pull request may close these issues.

QC: Add unit tests for Analyze_NormalApprox and Flag_NormalApprox
2 participants
@collleenmclaughlin @mattroumaya