Fix 790 - Data Analysis Vignette #802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated flowcharts to be used in data analysis vignette
mattroumaya
approved these changes
Oct 13, 2022
There was a problem hiding this comment.
Looks awesome, @collleenmclaughlin! Just a few nitpicky comments 🐱
Co-authored-by: Matt Roumaya <40671730+mattroumaya@users.noreply.github.com>
Co-authored-by: Matt Roumaya <40671730+mattroumaya@users.noreply.github.com>
Co-authored-by: Matt Roumaya <40671730+mattroumaya@users.noreply.github.com>
jwildfire
requested changes
Oct 14, 2022
There was a problem hiding this comment.
Very nice - This looks great!
My main feedback is that I want to treat this a bit more like a specific case-study, and move some of the more general info in to the data-pipeline vignette. Happy to have a quick chat if next steps aren't clear from my quick comments.
Co-authored-by: Jeremy Wildfire <jwildfire@gmail.com>
Co-authored-by: Jeremy Wildfire <jwildfire@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #790
Assess()flowchart