Fix #747 - Remove N from Assess() Functions #753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattroumaya
requested changes
Sep 22, 2022
There was a problem hiding this comment.
This looks great, @collleenmclaughlin!
Just a few minor tweaks noted in the review and below:
- Take a look at the documentation and make sure to remove the references to
N(like seen here). - After you've removed the references to
Nin the documentation, be sure to rundevtools::document()to update the documentation, and then commit and push those changes.
R/Visualize_Score.R
Outdated
Comment on lines
69
to
71
| if (all(c("Numerator", "Denominator") %in% names(dfFlagged))) { | ||
| sum(dfFlagged$Numerator) / sum(dfFlagged$Denominator) | ||
| } else { | ||
| sum(dfFlagged$N) / sum(dfFlagged$TotalCount) | ||
| } |
There was a problem hiding this comment.
Since dfFlagged across all assessments should now contain Numerator and Denominator, we should take out the ifelse and replace with:
yintercept = sum(dfFlagged$Numerator) / sum(dfFlagged$Denominator)
R/Analyze_Fisher.R
Outdated
| @@ -50,7 +50,7 @@ Analyze_Fisher <- function( | |||
| ) { | |||
| stopifnot( | |||
| "dfTransformed is not a data.frame" = is.data.frame(dfTransformed), | |||
| "One or more of these columns: GroupID, N, or the value in strOutcome not found in dfTransformed" = all(c("GroupID", "N", strOutcome) %in% names(dfTransformed)), | |||
| "One or more of these columns: GroupID, or the value in strOutcome not found in dfTransformed" = all(c("GroupID", strOutcome) %in% names(dfTransformed)), | |||
There was a problem hiding this comment.
Very minor suggestion, but as we've removed variables, it might be good to change to:
"GroupID or the value found in strOutcome not found in dfTransformed"
mattroumaya
approved these changes
Sep 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated Supporting Functions for
Assess()Functions to Remove $NRelated Issue: #747
Changes affect
AE_Assess(),Consent_Assess(),Disp_Assess(),IE_Assess(),LB_Assess(), andPD_Assess()functionsUpdates Made:
Analyze_Fisher.R,Analyze_Poisson.R,Summarize.R- removed N fromstopifnotsection and fromselect()Visualize_Score.R- removedsum(dfFlagged$N) / sum(dfFlagged$TotalCount)Transform_Count.R,Transform_Rank.R- removed N fromsummarize()Test Notes:
Once codes above were updated, I ran the codes under @examples in respective
Assess()function