Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #719 - refactor PD_Assess() #725

Merged
merged 3 commits into from
Sep 8, 2022
Merged

Fix #719 - refactor PD_Assess() #725

merged 3 commits into from
Sep 8, 2022

Conversation

mattroumaya
Copy link
Contributor

@mattroumaya mattroumaya commented Sep 8, 2022 •
edited by jwildfire
Loading

Overview

Fix #719

  • Added comments to identify assessment steps for AE and PD
  • Updated documentation

Test Notes/Sample Code

dm <- clindata::rawplus_dm 
dm$timeontreatment[is.na(dm$timeontreatment)] <- 0

dfInput <- PD_Map_Raw(
  dfs = list(
    dfSUBJ = dm,
    dfPD =  clindata::rawplus_protdev
  ),
  bQuiet=FALSE
)

pd <- PD_Assess(dfInput,bQuiet=FALSE)
pd_w <- PD_Assess(dfInput,bQuiet=FALSE, strMethod = "wilcoxon")
pd_i <- PD_Assess(dfInput,bQuiet=FALSE, strMethod = "identity")

@mattroumaya
start PD
f5530a4
@mattroumaya
ffwd
61a4b9f 
Merge branch 'dev' of github.com:Gilead-BioStats/gsm into fix-719

# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.
@mattroumaya
refactor PD_Assess()
178b64f
jwildfire
jwildfire approved these changes Sep 8, 2022
View reviewed changes
R/AE_Assess.R
@@ -60,14 +59,15 @@ AE_Assess <- function(dfInput,
lMapping = yaml::read_yaml(system.file("mappings", "AE_Assess.yaml", package = "gsm")),
strGroup = "Site",
bQuiet = TRUE) {

# data checking -----------------------------------------------------------
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this additional structure with the comments

@mattroumaya mattroumaya merged commit 2fe4461 into dev Sep 8, 2022
@mattroumaya mattroumaya deleted the fix-719 branch September 8, 2022 20:36
@mattroumaya mattroumaya self-assigned this Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwildfire jwildfire jwildfire approved these changes

@samussiah samussiah Awaiting requested review from samussiah

Assignees

@mattroumaya mattroumaya

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Refactor PD_Assess()
2 participants
@mattroumaya @jwildfire