Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 610 - flag on KRI in chisq and fisher #613

Merged
merged 2 commits into from
Jul 25, 2022
Merged

Fix 610 - flag on KRI in chisq and fisher #613

merged 2 commits into from
Jul 25, 2022

Conversation

mattroumaya
Copy link
Contributor

Overview

Fix #610 - flag on KRI for Analyze_Chisq() and Analyze_Fisher()

  • Unit tests will be resolved once PR 612 or 605 are merged

Test Notes/Sample Code

dfInput <- Disp_Map_Raw()
disp <- Disp_Assess(dfInput)

# now have -1, 0, 1 flags
table(disp$dfFlagged$Flag)

@mattroumaya mattroumaya self-assigned this Jul 22, 2022
samussiah
samussiah approved these changes Jul 25, 2022
View reviewed changes
Copy link
Contributor

@samussiah samussiah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got ittt, fix looks good!

@samussiah samussiah merged commit 564629b into dev Jul 25, 2022
@samussiah samussiah deleted the fix-610 branch July 25, 2022 19:48
@mattroumaya mattroumaya mentioned this pull request Aug 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samussiah samussiah samussiah approved these changes

@jwildfire jwildfire Awaiting requested review from jwildfire

Assignees

@mattroumaya mattroumaya

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bugfix: Disp chisq reflagging based on KRI
2 participants
@mattroumaya @samussiah