Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #521: Add function parameters to assessment workflows. #534

Merged
merged 3 commits into from
Jun 10, 2022
Merged

Conversation

samussiah
Copy link
Contributor

Overview

Add all Map and *_Assess function parameters to assessment workflows.

Test Notes/Sample Code

Modify params in ./inst/assessments/ae.yaml and run Study_Assess().

Notes:
I went ahead and formally added {gsm}-contained metadata defaults for lMapping in ./inst/mappings/. It's redundant with {clindata} but it allows {gsm} to operate without {clindata} metadata.

@samussiah samussiah linked an issue Jun 9, 2022 that may be closed by this pull request
Copy link
Contributor

@mattroumaya mattroumaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work @samussiah! This looks good to merge.


map(domains, function(test) {
domain <- test
map(domains, function(domain) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

@samussiah samussiah merged commit 8746577 into dev Jun 10, 2022
@samussiah samussiah deleted the fix-521 branch June 10, 2022 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QC: Add all configurable parameters in inst/assessment YAML files
2 participants