Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #462 - capture KRI and other associated metadata #527
Fix #462 - capture KRI and other associated metadata #527
Changes from all commits
5936af9
ea8595b
4f66741
eddaa44
2a564d8
4716b30
105aa14
7c7b85d
7dfba04
e5886fb
d7f4e37
909dddc
d663dd6
a7220a8
3fcf712
3574402
c192b6d
b471d08
bd9b51b
bc96160
9a3a306
c23fabb
d1a719c
b7113e8
8591393
b32100d
73337b1
c8f338d
672fe17
e25741c
5b520eb
e31e7b8
f54bae9
cdfd4a6
112aaba
4334b2f
00d2aad
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gwu05 Do we want to add a
strScoreCol
parameter here? We can set default to ".resid", but could also allow users to set up assessments that usepvalue
(or another parameter) as theScore
column for use in flagging.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's leave this hardcoded for now. Can revisit as needed if a new use case comes up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.