Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #434 - return correct bStatus #523

Merged
merged 2 commits into from
Jun 7, 2022
Merged

Fix #434 - return correct bStatus #523

merged 2 commits into from
Jun 7, 2022

Conversation

mattroumaya
Copy link
Contributor

Overview

Fix #434

  • Check that workflow exists in lAssessments before running assessment.
  • If workflow is missing, alert with cli and return bStatus == FALSE

Test Notes/Sample Code

 custom_assessments <- MakeAssessmentList()
 custom_assessments$ie$workflow <- NULL
 result <- Study_Assess(lAssessments = custom_assessments)

Confirm result$ie$bStatus == FALSE

@mattroumaya mattroumaya self-assigned this Jun 6, 2022
@mattroumaya mattroumaya added this to the v1.0.1 milestone Jun 6, 2022
lTags = c(lTags, lAssessment$tags),
bQuiet = bQuiet
)
if(exists("workflow", where = lAssessment)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice.

@mattroumaya mattroumaya merged commit 00f6a93 into dev Jun 7, 2022
@mattroumaya mattroumaya deleted the fix-434 branch June 7, 2022 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bugfix: bStatus should return FALSE when assessment is not run
2 participants