Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #458 #459

Merged
merged 1 commit into from
May 16, 2022
Merged

fix #458 #459

merged 1 commit into from
May 16, 2022

Conversation

samussiah
Copy link
Contributor

Overview

Resolve #458

Test Notes/Sample Code

Ensure the last statement below returns FALSE.

library(tidyverse)
library(gsm)
library(kableExtra)
results <- Study_Assess() %>%
    map(~.x$lResults) %>%
    compact()
allFindings <- results %>%
    map_df(~.x$dfSummary) %>%
    mutate(Flag = 1)
table <- gsm::Study_Table(allFindings)
identical(table$footnote, kableExtra::footnote)

@samussiah samussiah added this to the v1.0.0 milestone May 16, 2022
@samussiah samussiah requested a review from mattroumaya May 16, 2022 15:45
Copy link
Contributor

@mattroumaya mattroumaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! This looks good to me.

@mattroumaya mattroumaya merged commit 99ee6f1 into dev May 16, 2022
@mattroumaya mattroumaya deleted the fix-458 branch May 16, 2022 19:02
@mattroumaya mattroumaya added the bug Something isn't working label May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bugfix: Study_Table returns kableExtra::footnote when no outlier sites detected.
2 participants