Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #344 clindata update #346

Merged
merged 12 commits into from
Apr 6, 2022
Merged

Fix #344 clindata update #346

merged 12 commits into from
Apr 6, 2022

Conversation

mattroumaya
Copy link
Contributor

Overview

  • Change dfSubj to dfSUBJ
  • Change dfConsent to dfCONSENT
  • Update mappings in *_Map_Raw() functions
  • Update unit tests
  • Update examples

Risk Assessment

Risk: Medium - lots of minor changes to most functions and unit tests
Mitigation Strategy:

  • Qualification Testing - Included
  • Unit Testing - Included
  • Code Review - Included via PR review
  • QC Checklist - To be included with Release
  • Automated Testing - Package Checks via GitHub Actions

Notes: will need @kodesiba to merge into this branch with qualification updates to pass CI

@mattroumaya mattroumaya marked this pull request as ready for review April 6, 2022 18:33
@mattroumaya mattroumaya requested a review from jwildfire April 6, 2022 18:33
jwildfire
jwildfire approved these changes Apr 6, 2022
View reviewed changes
R/Consent_Map_Raw.R Outdated Show resolved Hide resolved
R/IE_Map_Raw.R Outdated Show resolved Hide resolved
R/PD_Map_Raw.R Outdated Show resolved Hide resolved
@jwildfire jwildfire merged commit 47e47f7 into dev Apr 6, 2022
@mattroumaya mattroumaya deleted the fix-344-clindata-update branch April 12, 2022 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwildfire jwildfire jwildfire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattroumaya @jwildfire