Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed Assess examples (names of return values) to reflect new bahav… #297

Merged
merged 1 commit into from
Mar 16, 2022

Conversation

dsanders2gilead
Copy link
Contributor

…iour where parameter bDataList has been removed

Overview

Changed examples in AE_Assess, PD_Assess, Consent_Assess, and IE_Assess to reflect new default behavior of Assess wrappers. (bDataList = BOOL has been removed, so now default is to return full list instead of just the summary df. The examples still worked, previously, but the naming of the return values could be confusing.

Risk Assessment

Non Existant.
Risk: Low/Medium/High
Mitigation Strategy:

  • Qualification Testing - [Included/Issue #X Filed]
  • Unit Testing - [Included/Issue #X Filed]
  • Code Review - [Included via PR review]
  • QC Checklist - [To be included with Release/Included in Comment]
  • Automated Testing - [Package Checks via GitHub Actions]

…iour where parameter bDataList has been removed
Copy link
Contributor

@mattroumaya mattroumaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mattroumaya mattroumaya merged commit 3441af4 into dev Mar 16, 2022
@mattroumaya mattroumaya deleted the fix-291-assess-examples branch April 12, 2022 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assess wrapper examples naming are based on old default bDatalist = False parameter
2 participants