Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs and tests for lConfig #2005

Merged
merged 4 commits into from
Jan 6, 2025
Merged

Add docs and tests for lConfig #2005

merged 4 commits into from
Jan 6, 2025

Conversation

lauramaxwell
Copy link
Contributor

@lauramaxwell lauramaxwell commented Dec 20, 2024

Overview

Update two tests to handle lConfig in test-RunWorkflow.R and update the Data Reporting vignette to use Ingest() in examples.

At this point, I think additional lConfig documentation/guidance should live in gsm.template since that is where loadData and saveData functionality is stored.

Test Notes/Sample Code

Connected Issues

@lauramaxwell lauramaxwell marked this pull request as ready for review December 20, 2024 19:07
@lauramaxwell lauramaxwell requested a review from samussiah January 6, 2025 16:07
Copy link
Contributor

@samussiah samussiah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree lConfig documentation mostly goes in gsm.template.

@samussiah samussiah merged commit fc335b5 into dev Jan 6, 2025
6 checks passed
@samussiah samussiah deleted the fix-1984 branch January 6, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QC: Add additional tests and for new lConfig requirements
2 participants