-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add subject disposition #2004
add subject disposition #2004
Conversation
@@ -35,6 +36,8 @@ spec: | |||
type: character | |||
subjid: | |||
type: character | |||
Status: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can remove this Status, right? looks like a duplicate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one captures subject status, to count the number of active subjects at the site.
@@ -41,6 +42,8 @@ spec: | |||
type: character | |||
subjid: | |||
type: character | |||
Status: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another duplicate Status as far as i can tell
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh wait, Mapped_SUBJ$Status
is used to calculate the number of active subjects. Raw_STUDY$Status
is a study-level attribute.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few tiny yaml edits that will also require a rerun of tests to update snaps, but other than that (and some investigation into the check failueres), this is looking good!
This PR kind of standardizes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Status' were not duplicates-misread the yamls. this looks great!
Overview
This branch adds subject-level status using the study completion domain, then aggregates at the study, site, and country levels.
Test Notes/Sample Code
Connected Issues