Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue in RunQuery related to incomplete column spec #1986

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

samussiah
Copy link
Contributor

Overview

An issue popped up running the Groups workflow where RunQuery couldn't find a type attribute on a column spec. This PR enforces the column spec data structure.

Test Notes/Sample Code

  # Create a sample data frame
  df <- data.frame(
    Name = c("John", "Jane", "Bob")
  )
  lColumnMapping <- list(
    emaN = list(
      source = 'Name'
    )
  )

  # Define the query and mapping
  query <- "SELECT Name as emaN FROM df WHERE Name LIKE '%o%'"

  # Call the RunQuery function and expect no error
  expect_no_error(result <- RunQuery(query, df, bUseSchema = T, lColumnMapping = lColumnMapping))
  expect_equal(class(result$emaN), "character")

Connected Issues

  • Closes #XXX

@samussiah samussiah marked this pull request as ready for review December 10, 2024 18:06
Copy link
Contributor

@lauramaxwell lauramaxwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good- thanks!

@lauramaxwell lauramaxwell merged commit 9e03fdc into v2.2.0-rc Dec 10, 2024
@lauramaxwell lauramaxwell deleted the fix-RunQuery branch December 10, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants