Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #1937 Display only results of metrics where data is available in reports #1953

Merged
merged 1 commit into from
Nov 20, 2024
+1 −1
Merged

Closes #1937 Display only results of metrics where data is available in reports #1953

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion inst/report/Report_KRI.Rmd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ Report_OverviewText(

```{r, echo=FALSE, results='asis'}

for (i in unique(params$dfMetrics$MetricID)) {
for (i in unique(params$dfResults$MetricID)) {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this really is the simplest way to fix it @lauramaxwell @samussiah , other "checks" may include making sure the metrics dataset coming out of 3_reporting/metrics.yaml only has metric IDs of the results?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh nice- i think this makes sense! way easier than what i was thinking we'd have to do 🎉

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless we want to put in additional guardrails, I think this is actually it

Copy link
Contributor

@samussiah samussiah Nov 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌 Makes sense to me!

lMetric <- params$dfMetrics %>% dplyr::filter(MetricID == i) %>% as.list

print(htmltools::h3(lMetric$Metric))
Expand Down