PD > IPD and display site activation / participant enrollment in study info. #1945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zdz2101
reviewed
Nov 14, 2024
R/util-CalculatePercentage.R
Outdated
| @@ -15,15 +15,22 @@ | |||
| #' @return A data frame containing two additional columns for the precentage value and associated string | |||
| #' @export | |||
| CalculatePercentage <- function(data, strCurrentCol, strTargetCol, strPercVal, strPercStrVal) { | |||
| if (!(strCurrentCol %in% names(data) & strTargetCol %in% names(data))) { | |||
| if (!(strCurrentCol %in% names(data))) { | |||
| cli::cli_abort("Check that both {strCurrentCol} and {strTargetCol} are in data") | |||
There was a problem hiding this comment.
Suggested change
| cli::cli_abort("Check that both {strCurrentCol} and {strTargetCol} are in data") | |
| cli::cli_abort("Check that {strCurrentCol} is in {data}") |
| } else { | ||
| data <- data %>% | ||
| dplyr::mutate( | ||
| {{ strPercStrVal }} := .data[[strCurrentCol]] |
There was a problem hiding this comment.
The argument name strPercStrVal feels a little deceiving here perhaps we should consider a renaming of the argument (?), and I could see why target/denominator numbers wouldn't be available soemtimes. If I'm interpreting correctly, if the denominator column isn't available you still want to be able to run this and return a new column which is just the numerator renamed?
There was a problem hiding this comment.
Yep, that would be my preference - if the target column is missing set site activation and participant enrollment to the numerator.
zdz2101
approved these changes
Nov 14, 2024
lauramaxwell
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Minor tweaks to:
1_mappings/STUDY.yaml: RemoveLabelsuffix2_metrics/cou0004.yaml:PD>IPD2_metrics/kri0004.yaml:PD>IPDR/Report_StudyInfo.R:SiteCount>SiteActivationandParticipantCount>ParticipantEnrollmentR/util-CountPercentage.R: works without target columnTest Notes/Sample Code
Connected Issues
SiteActivationandParticipantEnrollmentfields in study info. #1944