Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 1801 #1943

Merged
merged 8 commits into from
Nov 15, 2024
Merged

Fix 1801 #1943

merged 8 commits into from
Nov 15, 2024

Conversation

annezheng2
Copy link
Contributor

Overview

Replaces sqldf usage with duckdb for sql processing for RunQuery

Test Notes/Sample Code

Connected Issues

@annezheng2 annezheng2 linked an issue Nov 12, 2024 that may be closed by this pull request
Feature: Convert RunQuery to use duckdb #1801
Closed
lauramaxwell
lauramaxwell approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@lauramaxwell lauramaxwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated ApplySpec() to remove the name__class format/method that sqldf was using. Dates are passing through and retaining format without trouble, which is great! This is ready to go.

@lauramaxwell lauramaxwell merged commit 75d883f into dev Nov 15, 2024
6 checks passed
@lauramaxwell lauramaxwell deleted the fix-1801 branch November 15, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lauramaxwell lauramaxwell lauramaxwell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Convert RunQuery to use duckdb
2 participants
@annezheng2 @lauramaxwell