Refactor Flag functions #1920
Merged
Refactor Flag functions #1920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lauramaxwell @zdz2101 this is ready for an initial review once v2.2 is released. I fixed unit tests, but would also be great if yall could clean up pkgdown and re-run qualification tests to confirm nothing is broken. cc: @samussiah |
Merge branch 'dev' into fix-1911 # Conflicts: # R/Report_Timeline.R
zdz2101
reviewed
Dec 13, 2024
Merge branch 'dev' into fix-1911 # Conflicts: # R/Flag.R # R/Flag_Fisher.R # R/Flag_NormalApprox.R # R/Flag_Poisson.R
lauramaxwell
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Starting work to support PK KRI per #1911. First steps included in this PR:
Flag()function to be a bit more flexible per Feature: Create a simplified Flag() function that can be used for all common use cases. #1973.Make_Timeline()per Feature: Remove Make_Timeline function #1978MakeBounds()doesn't bomb for "identity" analysis per Feature: Add support for "identity" analysis in MakeBounds #1919Test Notes/Sample Code
See updated test-that tests for
Flag()functionality.Connected Issues